net: phy: remove calls to genphy_config_init
Supported PHY features are either auto-detected or explicitly set. In both cases calling genphy_config_init isn't needed. All that genphy_config_init does is removing features that are set as supported but can't be auto-detected. Basically it duplicates the code in genphy_read_abilities. Therefore remove such calls from all PHY drivers. v2: - remove call also from new adin PHY driver v3: - pass NULL as config_init function pointer for dp83848 Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
a4d2113e46
commit
c227ce4423
@@ -68,13 +68,8 @@ static int dp83848_config_intr(struct phy_device *phydev)
|
||||
|
||||
static int dp83848_config_init(struct phy_device *phydev)
|
||||
{
|
||||
int err;
|
||||
int val;
|
||||
|
||||
err = genphy_config_init(phydev);
|
||||
if (err < 0)
|
||||
return err;
|
||||
|
||||
/* DP83620 always reports Auto Negotiation Ability on BMSR. Instead,
|
||||
* we check initial value of BMCR Auto negotiation enable bit
|
||||
*/
|
||||
@@ -113,13 +108,13 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
|
||||
|
||||
static struct phy_driver dp83848_driver[] = {
|
||||
DP83848_PHY_DRIVER(TI_DP83848C_PHY_ID, "TI DP83848C 10/100 Mbps PHY",
|
||||
genphy_config_init),
|
||||
NULL),
|
||||
DP83848_PHY_DRIVER(NS_DP83848C_PHY_ID, "NS DP83848C 10/100 Mbps PHY",
|
||||
genphy_config_init),
|
||||
NULL),
|
||||
DP83848_PHY_DRIVER(TI_DP83620_PHY_ID, "TI DP83620 10/100 Mbps PHY",
|
||||
dp83848_config_init),
|
||||
DP83848_PHY_DRIVER(TLK10X_PHY_ID, "TI TLK10X 10/100 Mbps PHY",
|
||||
genphy_config_init),
|
||||
NULL),
|
||||
};
|
||||
module_phy_driver(dp83848_driver);
|
||||
|
||||
|
Reference in New Issue
Block a user