xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qla2xxx: Use kmemdup instead of kmalloc + memcpy

Browse Source 
This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Benoit Taine
2014-05-26 17:21:16 +02:00
committed by Christoph Hellwig
parent 3d30b439f0
commit c1818f17b5
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/scsi/qla2xxx/qla_mbx.c
View File

@@ -1319,7 +1319,7 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len)
left = 0; left = 0;
list = kzalloc(dma_size, GFP_KERNEL); list = kmemdup(pmap, dma_size, GFP_KERNEL);
if (!list) { if (!list) {
ql_log(ql_log_warn, vha, 0x1140, ql_log(ql_log_warn, vha, 0x1140,
"%s(%ld): failed to allocate node names list " "%s(%ld): failed to allocate node names list "
@@ -1328,7 +1328,6 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len)
goto out_free; goto out_free;
} }
memcpy(list, pmap, dma_size);
restart: restart:
dma_free_coherent(&ha->pdev->dev, dma_size, pmap, pmap_dma); dma_free_coherent(&ha->pdev->dev, dma_size, pmap, pmap_dma);
} }