media: use strscpy() instead of strlcpy()
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
@@ -390,10 +390,10 @@ static int coda_querycap(struct file *file, void *priv,
|
||||
{
|
||||
struct coda_ctx *ctx = fh_to_ctx(priv);
|
||||
|
||||
strlcpy(cap->driver, CODA_NAME, sizeof(cap->driver));
|
||||
strlcpy(cap->card, coda_product_name(ctx->dev->devtype->product),
|
||||
strscpy(cap->driver, CODA_NAME, sizeof(cap->driver));
|
||||
strscpy(cap->card, coda_product_name(ctx->dev->devtype->product),
|
||||
sizeof(cap->card));
|
||||
strlcpy(cap->bus_info, "platform:" CODA_NAME, sizeof(cap->bus_info));
|
||||
strscpy(cap->bus_info, "platform:" CODA_NAME, sizeof(cap->bus_info));
|
||||
cap->device_caps = V4L2_CAP_VIDEO_M2M | V4L2_CAP_STREAMING;
|
||||
cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
|
||||
|
||||
@@ -2408,7 +2408,7 @@ static int coda_register_device(struct coda_dev *dev, int i)
|
||||
if (i >= dev->devtype->num_vdevs)
|
||||
return -EINVAL;
|
||||
|
||||
strlcpy(vfd->name, dev->devtype->vdevs[i]->name, sizeof(vfd->name));
|
||||
strscpy(vfd->name, dev->devtype->vdevs[i]->name, sizeof(vfd->name));
|
||||
vfd->fops = &coda_fops;
|
||||
vfd->ioctl_ops = &coda_ioctl_ops;
|
||||
vfd->release = video_device_release_empty,
|
||||
|
Reference in New Issue
Block a user