Input: ad714x - use DMA-safe buffers for spi_write()
spi_write() requires use of DMA-safe (cacheline aligned) buffers. Also use the same buffers when reading data since to avoid extra locking and potential memory allocation in spi_write_then_read(). Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
@@ -59,7 +59,6 @@
|
||||
#define STAGE11_AMBIENT 0x27D
|
||||
|
||||
#define PER_STAGE_REG_NUM 36
|
||||
#define STAGE_NUM 12
|
||||
#define STAGE_CFGREG_NUM 8
|
||||
#define SYS_CFGREG_NUM 8
|
||||
|
||||
@@ -124,28 +123,6 @@ struct ad714x_driver_data {
|
||||
* information to integrate all things which will be private data
|
||||
* of spi/i2c device
|
||||
*/
|
||||
struct ad714x_chip {
|
||||
unsigned short h_state;
|
||||
unsigned short l_state;
|
||||
unsigned short c_state;
|
||||
unsigned short adc_reg[STAGE_NUM];
|
||||
unsigned short amb_reg[STAGE_NUM];
|
||||
unsigned short sensor_val[STAGE_NUM];
|
||||
|
||||
struct ad714x_platform_data *hw;
|
||||
struct ad714x_driver_data *sw;
|
||||
|
||||
int irq;
|
||||
struct device *dev;
|
||||
ad714x_read_t read;
|
||||
ad714x_write_t write;
|
||||
|
||||
struct mutex mutex;
|
||||
|
||||
unsigned product;
|
||||
unsigned version;
|
||||
};
|
||||
|
||||
static void ad714x_use_com_int(struct ad714x_chip *ad714x,
|
||||
int start_stage, int end_stage)
|
||||
{
|
||||
@@ -154,13 +131,13 @@ static void ad714x_use_com_int(struct ad714x_chip *ad714x,
|
||||
|
||||
mask = ((1 << (end_stage + 1)) - 1) - ((1 << start_stage) - 1);
|
||||
|
||||
ad714x->read(ad714x->dev, STG_COM_INT_EN_REG, &data);
|
||||
ad714x->read(ad714x, STG_COM_INT_EN_REG, &data);
|
||||
data |= 1 << end_stage;
|
||||
ad714x->write(ad714x->dev, STG_COM_INT_EN_REG, data);
|
||||
ad714x->write(ad714x, STG_COM_INT_EN_REG, data);
|
||||
|
||||
ad714x->read(ad714x->dev, STG_HIGH_INT_EN_REG, &data);
|
||||
ad714x->read(ad714x, STG_HIGH_INT_EN_REG, &data);
|
||||
data &= ~mask;
|
||||
ad714x->write(ad714x->dev, STG_HIGH_INT_EN_REG, data);
|
||||
ad714x->write(ad714x, STG_HIGH_INT_EN_REG, data);
|
||||
}
|
||||
|
||||
static void ad714x_use_thr_int(struct ad714x_chip *ad714x,
|
||||
@@ -171,13 +148,13 @@ static void ad714x_use_thr_int(struct ad714x_chip *ad714x,
|
||||
|
||||
mask = ((1 << (end_stage + 1)) - 1) - ((1 << start_stage) - 1);
|
||||
|
||||
ad714x->read(ad714x->dev, STG_COM_INT_EN_REG, &data);
|
||||
ad714x->read(ad714x, STG_COM_INT_EN_REG, &data);
|
||||
data &= ~(1 << end_stage);
|
||||
ad714x->write(ad714x->dev, STG_COM_INT_EN_REG, data);
|
||||
ad714x->write(ad714x, STG_COM_INT_EN_REG, data);
|
||||
|
||||
ad714x->read(ad714x->dev, STG_HIGH_INT_EN_REG, &data);
|
||||
ad714x->read(ad714x, STG_HIGH_INT_EN_REG, &data);
|
||||
data |= mask;
|
||||
ad714x->write(ad714x->dev, STG_HIGH_INT_EN_REG, data);
|
||||
ad714x->write(ad714x, STG_HIGH_INT_EN_REG, data);
|
||||
}
|
||||
|
||||
static int ad714x_cal_highest_stage(struct ad714x_chip *ad714x,
|
||||
@@ -274,10 +251,8 @@ static void ad714x_slider_cal_sensor_val(struct ad714x_chip *ad714x, int idx)
|
||||
int i;
|
||||
|
||||
for (i = hw->start_stage; i <= hw->end_stage; i++) {
|
||||
ad714x->read(ad714x->dev, CDC_RESULT_S0 + i,
|
||||
&ad714x->adc_reg[i]);
|
||||
ad714x->read(ad714x->dev,
|
||||
STAGE0_AMBIENT + i * PER_STAGE_REG_NUM,
|
||||
ad714x->read(ad714x, CDC_RESULT_S0 + i, &ad714x->adc_reg[i]);
|
||||
ad714x->read(ad714x, STAGE0_AMBIENT + i * PER_STAGE_REG_NUM,
|
||||
&ad714x->amb_reg[i]);
|
||||
|
||||
ad714x->sensor_val[i] = abs(ad714x->adc_reg[i] -
|
||||
@@ -445,10 +420,8 @@ static void ad714x_wheel_cal_sensor_val(struct ad714x_chip *ad714x, int idx)
|
||||
int i;
|
||||
|
||||
for (i = hw->start_stage; i <= hw->end_stage; i++) {
|
||||
ad714x->read(ad714x->dev, CDC_RESULT_S0 + i,
|
||||
&ad714x->adc_reg[i]);
|
||||
ad714x->read(ad714x->dev,
|
||||
STAGE0_AMBIENT + i * PER_STAGE_REG_NUM,
|
||||
ad714x->read(ad714x, CDC_RESULT_S0 + i, &ad714x->adc_reg[i]);
|
||||
ad714x->read(ad714x, STAGE0_AMBIENT + i * PER_STAGE_REG_NUM,
|
||||
&ad714x->amb_reg[i]);
|
||||
if (ad714x->adc_reg[i] > ad714x->amb_reg[i])
|
||||
ad714x->sensor_val[i] = ad714x->adc_reg[i] -
|
||||
@@ -598,10 +571,8 @@ static void touchpad_cal_sensor_val(struct ad714x_chip *ad714x, int idx)
|
||||
int i;
|
||||
|
||||
for (i = hw->x_start_stage; i <= hw->x_end_stage; i++) {
|
||||
ad714x->read(ad714x->dev, CDC_RESULT_S0 + i,
|
||||
&ad714x->adc_reg[i]);
|
||||
ad714x->read(ad714x->dev,
|
||||
STAGE0_AMBIENT + i * PER_STAGE_REG_NUM,
|
||||
ad714x->read(ad714x, CDC_RESULT_S0 + i, &ad714x->adc_reg[i]);
|
||||
ad714x->read(ad714x, STAGE0_AMBIENT + i * PER_STAGE_REG_NUM,
|
||||
&ad714x->amb_reg[i]);
|
||||
if (ad714x->adc_reg[i] > ad714x->amb_reg[i])
|
||||
ad714x->sensor_val[i] = ad714x->adc_reg[i] -
|
||||
@@ -891,7 +862,7 @@ static int ad714x_hw_detect(struct ad714x_chip *ad714x)
|
||||
{
|
||||
unsigned short data;
|
||||
|
||||
ad714x->read(ad714x->dev, AD714X_PARTID_REG, &data);
|
||||
ad714x->read(ad714x, AD714X_PARTID_REG, &data);
|
||||
switch (data & 0xFFF0) {
|
||||
case AD7142_PARTID:
|
||||
ad714x->product = 0x7142;
|
||||
@@ -940,23 +911,22 @@ static void ad714x_hw_init(struct ad714x_chip *ad714x)
|
||||
for (i = 0; i < STAGE_NUM; i++) {
|
||||
reg_base = AD714X_STAGECFG_REG + i * STAGE_CFGREG_NUM;
|
||||
for (j = 0; j < STAGE_CFGREG_NUM; j++)
|
||||
ad714x->write(ad714x->dev, reg_base + j,
|
||||
ad714x->write(ad714x, reg_base + j,
|
||||
ad714x->hw->stage_cfg_reg[i][j]);
|
||||
}
|
||||
|
||||
for (i = 0; i < SYS_CFGREG_NUM; i++)
|
||||
ad714x->write(ad714x->dev, AD714X_SYSCFG_REG + i,
|
||||
ad714x->write(ad714x, AD714X_SYSCFG_REG + i,
|
||||
ad714x->hw->sys_cfg_reg[i]);
|
||||
for (i = 0; i < SYS_CFGREG_NUM; i++)
|
||||
ad714x->read(ad714x->dev, AD714X_SYSCFG_REG + i,
|
||||
&data);
|
||||
ad714x->read(ad714x, AD714X_SYSCFG_REG + i, &data);
|
||||
|
||||
ad714x->write(ad714x->dev, AD714X_STG_CAL_EN_REG, 0xFFF);
|
||||
ad714x->write(ad714x, AD714X_STG_CAL_EN_REG, 0xFFF);
|
||||
|
||||
/* clear all interrupts */
|
||||
ad714x->read(ad714x->dev, STG_LOW_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x->dev, STG_HIGH_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x->dev, STG_COM_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x, STG_LOW_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x, STG_HIGH_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x, STG_COM_INT_STA_REG, &data);
|
||||
}
|
||||
|
||||
static irqreturn_t ad714x_interrupt_thread(int irq, void *data)
|
||||
@@ -966,9 +936,9 @@ static irqreturn_t ad714x_interrupt_thread(int irq, void *data)
|
||||
|
||||
mutex_lock(&ad714x->mutex);
|
||||
|
||||
ad714x->read(ad714x->dev, STG_LOW_INT_STA_REG, &ad714x->l_state);
|
||||
ad714x->read(ad714x->dev, STG_HIGH_INT_STA_REG, &ad714x->h_state);
|
||||
ad714x->read(ad714x->dev, STG_COM_INT_STA_REG, &ad714x->c_state);
|
||||
ad714x->read(ad714x, STG_LOW_INT_STA_REG, &ad714x->l_state);
|
||||
ad714x->read(ad714x, STG_HIGH_INT_STA_REG, &ad714x->h_state);
|
||||
ad714x->read(ad714x, STG_COM_INT_STA_REG, &ad714x->c_state);
|
||||
|
||||
for (i = 0; i < ad714x->hw->button_num; i++)
|
||||
ad714x_button_state_machine(ad714x, i);
|
||||
@@ -1245,7 +1215,7 @@ int ad714x_disable(struct ad714x_chip *ad714x)
|
||||
mutex_lock(&ad714x->mutex);
|
||||
|
||||
data = ad714x->hw->sys_cfg_reg[AD714X_PWR_CTRL] | 0x3;
|
||||
ad714x->write(ad714x->dev, AD714X_PWR_CTRL, data);
|
||||
ad714x->write(ad714x, AD714X_PWR_CTRL, data);
|
||||
|
||||
mutex_unlock(&ad714x->mutex);
|
||||
|
||||
@@ -1263,16 +1233,16 @@ int ad714x_enable(struct ad714x_chip *ad714x)
|
||||
|
||||
/* resume to non-shutdown mode */
|
||||
|
||||
ad714x->write(ad714x->dev, AD714X_PWR_CTRL,
|
||||
ad714x->write(ad714x, AD714X_PWR_CTRL,
|
||||
ad714x->hw->sys_cfg_reg[AD714X_PWR_CTRL]);
|
||||
|
||||
/* make sure the interrupt output line is not low level after resume,
|
||||
* otherwise we will get no chance to enter falling-edge irq again
|
||||
*/
|
||||
|
||||
ad714x->read(ad714x->dev, STG_LOW_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x->dev, STG_HIGH_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x->dev, STG_COM_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x, STG_LOW_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x, STG_HIGH_INT_STA_REG, &data);
|
||||
ad714x->read(ad714x, STG_COM_INT_STA_REG, &data);
|
||||
|
||||
mutex_unlock(&ad714x->mutex);
|
||||
|
||||
|
Reference in New Issue
Block a user