drm/omap: check if rotation is supported before commit
omapdrm is missing a check on the validity of the rotation property. This leads to omapdrm possibly trying to use rotation on non-rotateable framebuffer, which causes the overlay setup to fail. This patch adds the necessary check to omap_plane_atomic_check(). Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
@@ -145,6 +145,14 @@ static uint32_t get_linear_addr(struct plane *plane,
|
||||
return plane->paddr + offset;
|
||||
}
|
||||
|
||||
bool omap_framebuffer_supports_rotation(struct drm_framebuffer *fb)
|
||||
{
|
||||
struct omap_framebuffer *omap_fb = to_omap_framebuffer(fb);
|
||||
struct plane *plane = &omap_fb->planes[0];
|
||||
|
||||
return omap_gem_flags(plane->bo) & OMAP_BO_TILED;
|
||||
}
|
||||
|
||||
/* update ovl info for scanout, handles cases of multi-planar fb's, etc.
|
||||
*/
|
||||
void omap_framebuffer_update_scanout(struct drm_framebuffer *fb,
|
||||
|
Reference in New Issue
Block a user