[media] Media: remove incorrect __init/__exit markups
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Similarly probe() methods should not be marked __init unless platform_driver_probe() is used. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Sakari Ailus <sakari.ailus@iki.fi> Acked-by: Timo Kokkonen <timo.t.kokkonen@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cette révision appartient à :

révisé par
Mauro Carvalho Chehab

Parent
4458a54c5e
révision
bf30690029
@@ -447,7 +447,7 @@ free_and_quit:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int __exit adp1653_remove(struct i2c_client *client)
|
||||
static int adp1653_remove(struct i2c_client *client)
|
||||
{
|
||||
struct v4l2_subdev *subdev = i2c_get_clientdata(client);
|
||||
struct adp1653_flash *flash = to_adp1653_flash(subdev);
|
||||
@@ -476,7 +476,7 @@ static struct i2c_driver adp1653_i2c_driver = {
|
||||
.pm = &adp1653_pm_ops,
|
||||
},
|
||||
.probe = adp1653_probe,
|
||||
.remove = __exit_p(adp1653_remove),
|
||||
.remove = adp1653_remove,
|
||||
.id_table = adp1653_id_table,
|
||||
};
|
||||
|
||||
|
@@ -2833,7 +2833,7 @@ static int smiapp_probe(struct i2c_client *client,
|
||||
sensor->src->pads, 0);
|
||||
}
|
||||
|
||||
static int __exit smiapp_remove(struct i2c_client *client)
|
||||
static int smiapp_remove(struct i2c_client *client)
|
||||
{
|
||||
struct v4l2_subdev *subdev = i2c_get_clientdata(client);
|
||||
struct smiapp_sensor *sensor = to_smiapp_sensor(subdev);
|
||||
@@ -2881,7 +2881,7 @@ static struct i2c_driver smiapp_i2c_driver = {
|
||||
.pm = &smiapp_pm_ops,
|
||||
},
|
||||
.probe = smiapp_probe,
|
||||
.remove = __exit_p(smiapp_remove),
|
||||
.remove = smiapp_remove,
|
||||
.id_table = smiapp_id_table,
|
||||
};
|
||||
|
||||
|
Référencer dans un nouveau ticket
Bloquer un utilisateur