drm/ttm: Quick-test mmap offset in ttm_bo_mmap()
A BO's address has to be at least the minimum offset. Sharing this test in ttm_bo_mmap() removes code from drivers. A full buffer-address validation is still done within drm_vma_offset_lockup_locked(). Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Christian König <christian.koenig@amd.com> Acked-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:

committed by
Alex Deucher

parent
7d1500f9fb
commit
bed2dd8421
@@ -63,15 +63,10 @@ static vm_fault_t qxl_ttm_fault(struct vm_fault *vmf)
|
||||
|
||||
int qxl_mmap(struct file *filp, struct vm_area_struct *vma)
|
||||
{
|
||||
struct drm_file *file_priv;
|
||||
struct qxl_device *qdev;
|
||||
int r;
|
||||
struct drm_file *file_priv = filp->private_data;
|
||||
struct qxl_device *qdev = file_priv->minor->dev->dev_private;
|
||||
|
||||
if (unlikely(vma->vm_pgoff < DRM_FILE_PAGE_OFFSET))
|
||||
return -EINVAL;
|
||||
|
||||
file_priv = filp->private_data;
|
||||
qdev = file_priv->minor->dev->dev_private;
|
||||
if (qdev == NULL) {
|
||||
DRM_ERROR(
|
||||
"filp->private_data->minor->dev->dev_private == NULL\n");
|
||||
|
Reference in New Issue
Block a user