fs: fix kernel_read prototype
Use proper ssize_t and size_t types for the return value and count argument, move the offset last and make it an in/out argument like all other read/write helpers, and make the buf argument a void pointer to get rid of lots of casts in the callers. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:

committed by
Al Viro

parent
c41fbad015
commit
bdd1d2d3d2
@@ -272,6 +272,7 @@ static int p9_fd_read(struct p9_client *client, void *v, int len)
|
||||
{
|
||||
int ret;
|
||||
struct p9_trans_fd *ts = NULL;
|
||||
loff_t pos;
|
||||
|
||||
if (client && client->status != Disconnected)
|
||||
ts = client->trans;
|
||||
@@ -282,7 +283,8 @@ static int p9_fd_read(struct p9_client *client, void *v, int len)
|
||||
if (!(ts->rd->f_flags & O_NONBLOCK))
|
||||
p9_debug(P9_DEBUG_ERROR, "blocking read ...\n");
|
||||
|
||||
ret = kernel_read(ts->rd, ts->rd->f_pos, v, len);
|
||||
pos = ts->rd->f_pos;
|
||||
ret = kernel_read(ts->rd, v, len, &pos);
|
||||
if (ret <= 0 && ret != -ERESTARTSYS && ret != -EAGAIN)
|
||||
client->status = Disconnected;
|
||||
return ret;
|
||||
|
Reference in New Issue
Block a user