xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sfc: Use swap() instead of open coding it

Browse Source 
[ Upstream commit 0cf765fb00ce083c017f2571ac449cf7912cdb06 ]

Clean the following coccicheck warning:

./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity
for swap().

./drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity
for swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiapeng Chong
2022-01-05 23:22:37 +08:00
committed by Greg Kroah-Hartman
parent 33c93f6e55
commit bdb8d4aed1
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/ethernet/sfc/efx_channels.c
View File

@@ -797,11 +797,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries)
old_txq_entries = efx->txq_entries; old_txq_entries = efx->txq_entries;
efx->rxq_entries = rxq_entries; efx->rxq_entries = rxq_entries;
efx->txq_entries = txq_entries; efx->txq_entries = txq_entries;
for (i = 0; i < efx->n_channels; i++) { for (i = 0; i < efx->n_channels; i++)
channel = efx->channel[i]; swap(efx->channel[i], other_channel[i]);
efx->channel[i] = other_channel[i];
other_channel[i] = channel;
}
/* Restart buffer table allocation */ /* Restart buffer table allocation */
efx->next_buffer_table = next_buffer_table; efx->next_buffer_table = next_buffer_table;
@@ -843,11 +840,8 @@ rollback:
/* Swap back */ /* Swap back */
efx->rxq_entries = old_rxq_entries; efx->rxq_entries = old_rxq_entries;
efx->txq_entries = old_txq_entries; efx->txq_entries = old_txq_entries;
for (i = 0; i < efx->n_channels; i++) { for (i = 0; i < efx->n_channels; i++)
channel = efx->channel[i]; swap(efx->channel[i], other_channel[i]);
efx->channel[i] = other_channel[i];
other_channel[i] = channel;
}
goto out; goto out;
} }