xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/sysdev: fix incorrect use to determine if list is empty

Browse Source 
[ Upstream commit fa1321b11bd01752f5be2415e74a0e1a7c378262 ]

'gtm' will *always* be set by list_for_each_entry().
It is incorrect to assume that the iterator value will be NULL if the
list is empty.

Instead of checking the pointer it should be checked if
the list is empty.

Fixes: 83ff9dcf37 ("powerpc/sysdev: implement FSL GTM support")
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220228142434.576226-1-jakobkoschel@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jakob Koschel
2022-02-28 15:24:33 +01:00
committed by Greg Kroah-Hartman
parent ab0a335b54
commit bcf93175ed
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
arch/powerpc/sysdev/fsl_gtm.c
View File

@@ -86,7 +86,7 @@ static LIST_HEAD(gtms);
*/ */
struct gtm_timer *gtm_get_timer16(void) struct gtm_timer *gtm_get_timer16(void)
{ {
struct gtm *gtm = NULL; struct gtm *gtm;
int i; int i;
list_for_each_entry(gtm, &gtms, list_node) { list_for_each_entry(gtm, &gtms, list_node) {
@@ -103,7 +103,7 @@ struct gtm_timer *gtm_get_timer16(void)
spin_unlock_irq(&gtm->lock); spin_unlock_irq(&gtm->lock);
} }
if (gtm) if (!list_empty(&gtms))
return ERR_PTR(-EBUSY); return ERR_PTR(-EBUSY);
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
} }