fs/ntfs: use timespec64 directly for timestamp conversion
Now that the VFS has been converted from timespec to timespec64 timestamps, only the conversion to/from ntfs timestamps uses 32-bit seconds. This changes that last missing piece to get the ntfs implementation y2038 safe on 32-bit architectures. Link: http://lkml.kernel.org/r/20180718115017.742609-2-arnd@arndb.de Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Anton Altaparmakov <anton@tuxera.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
a3fda0ffea
commit
bcf451ecfc
@@ -667,18 +667,18 @@ static int ntfs_read_locked_inode(struct inode *vi)
|
||||
* mtime is the last change of the data within the file. Not changed
|
||||
* when only metadata is changed, e.g. a rename doesn't affect mtime.
|
||||
*/
|
||||
vi->i_mtime = timespec_to_timespec64(ntfs2utc(si->last_data_change_time));
|
||||
vi->i_mtime = ntfs2utc(si->last_data_change_time);
|
||||
/*
|
||||
* ctime is the last change of the metadata of the file. This obviously
|
||||
* always changes, when mtime is changed. ctime can be changed on its
|
||||
* own, mtime is then not changed, e.g. when a file is renamed.
|
||||
*/
|
||||
vi->i_ctime = timespec_to_timespec64(ntfs2utc(si->last_mft_change_time));
|
||||
vi->i_ctime = ntfs2utc(si->last_mft_change_time);
|
||||
/*
|
||||
* Last access to the data within the file. Not changed during a rename
|
||||
* for example but changed whenever the file is written to.
|
||||
*/
|
||||
vi->i_atime = timespec_to_timespec64(ntfs2utc(si->last_access_time));
|
||||
vi->i_atime = ntfs2utc(si->last_access_time);
|
||||
|
||||
/* Find the attribute list attribute if present. */
|
||||
ntfs_attr_reinit_search_ctx(ctx);
|
||||
@@ -2997,7 +2997,7 @@ int __ntfs_write_inode(struct inode *vi, int sync)
|
||||
si = (STANDARD_INFORMATION*)((u8*)ctx->attr +
|
||||
le16_to_cpu(ctx->attr->data.resident.value_offset));
|
||||
/* Update the access times if they have changed. */
|
||||
nt = utc2ntfs(timespec64_to_timespec(vi->i_mtime));
|
||||
nt = utc2ntfs(vi->i_mtime);
|
||||
if (si->last_data_change_time != nt) {
|
||||
ntfs_debug("Updating mtime for inode 0x%lx: old = 0x%llx, "
|
||||
"new = 0x%llx", vi->i_ino, (long long)
|
||||
@@ -3006,7 +3006,7 @@ int __ntfs_write_inode(struct inode *vi, int sync)
|
||||
si->last_data_change_time = nt;
|
||||
modified = true;
|
||||
}
|
||||
nt = utc2ntfs(timespec64_to_timespec(vi->i_ctime));
|
||||
nt = utc2ntfs(vi->i_ctime);
|
||||
if (si->last_mft_change_time != nt) {
|
||||
ntfs_debug("Updating ctime for inode 0x%lx: old = 0x%llx, "
|
||||
"new = 0x%llx", vi->i_ino, (long long)
|
||||
@@ -3015,7 +3015,7 @@ int __ntfs_write_inode(struct inode *vi, int sync)
|
||||
si->last_mft_change_time = nt;
|
||||
modified = true;
|
||||
}
|
||||
nt = utc2ntfs(timespec64_to_timespec(vi->i_atime));
|
||||
nt = utc2ntfs(vi->i_atime);
|
||||
if (si->last_access_time != nt) {
|
||||
ntfs_debug("Updating atime for inode 0x%lx: old = 0x%llx, "
|
||||
"new = 0x%llx", vi->i_ino,
|
||||
|
Reference in New Issue
Block a user