afs: Deal with an empty callback array
Servers may send a callback array that is the same size as the FID array, or an empty array. If the callback count is 0, the code would attempt to read (fid_count * 12) bytes of data, which would fail and result in an unmarshalling error. This would lead to stale data for remotely modified files or directories. Store the callback array size in the internal afs_call structure and use that to determine the amount of data to read. Signed-off-by: Marc Dionne <marc.dionne@auristor.com>
This commit is contained in:

committed by
David Howells

parent
627f46943f
commit
bcd89270d9
@@ -90,7 +90,10 @@ struct afs_call {
|
||||
unsigned request_size; /* size of request data */
|
||||
unsigned reply_max; /* maximum size of reply */
|
||||
unsigned first_offset; /* offset into mapping[first] */
|
||||
unsigned last_to; /* amount of mapping[last] */
|
||||
union {
|
||||
unsigned last_to; /* amount of mapping[last] */
|
||||
unsigned count2; /* count used in unmarshalling */
|
||||
};
|
||||
unsigned char unmarshall; /* unmarshalling phase */
|
||||
bool incoming; /* T if incoming call */
|
||||
bool send_pages; /* T if data from mapping should be sent */
|
||||
|
Reference in New Issue
Block a user