xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amd/pp: Refine function iceland_start_smu

Browse Source 
if upload firmware failed, no matter how many times
the function runs again, the same error will be encountered.
so remove the duplicated code.

Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Rex Zhu
2018-09-29 13:28:20 +08:00
committed by Alex Deucher
parent 44779b43f1
commit bcb7c4e8b4
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c
View File

@@ -234,22 +234,12 @@ static int iceland_start_smu(struct pp_hwmgr *hwmgr)
{ {
int result; int result;
result = iceland_smu_upload_firmware_image(hwmgr);
if (result)
return result;
result = iceland_smu_start_smc(hwmgr);
if (result)
return result;
if (!smu7_is_smc_ram_running(hwmgr)) { if (!smu7_is_smc_ram_running(hwmgr)) {
pr_info("smu not running, upload firmware again \n");
result = iceland_smu_upload_firmware_image(hwmgr); result = iceland_smu_upload_firmware_image(hwmgr);
if (result) if (result)
return result; return result;
result = iceland_smu_start_smc(hwmgr); iceland_smu_start_smc(hwmgr);
if (result)
return result;
} }
result = smu7_request_smu_load_fw(hwmgr); result = smu7_request_smu_load_fw(hwmgr);