xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: omap-sham - Fix PM reference leak in omap sham ops

Browse Source 
[ Upstream commit ca323b2c61ec321eb9f2179a405b9c34cdb4f553 ]

pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes: 604c31039d ("crypto: omap-sham - Check for return value from pm_runtime_get_sync")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Zhang Qilong
2021-06-01 22:51:18 +08:00
committed by Greg Kroah-Hartman
parent 615f2f5e7e
commit bc50c40385
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/crypto/omap-sham.c
View File

@@ -371,7 +371,7 @@ static int omap_sham_hw_init(struct omap_sham_dev *dd)
{ {
int err; int err;
err = pm_runtime_get_sync(dd->dev); err = pm_runtime_resume_and_get(dd->dev);
if (err < 0) { if (err < 0) {
dev_err(dd->dev, "failed to get sync: %d\n", err); dev_err(dd->dev, "failed to get sync: %d\n", err);
return err; return err;
@@ -2243,7 +2243,7 @@ static int omap_sham_suspend(struct device *dev)
static int omap_sham_resume(struct device *dev) static int omap_sham_resume(struct device *dev)
{ {
int err = pm_runtime_get_sync(dev); int err = pm_runtime_resume_and_get(dev);
if (err < 0) { if (err < 0) {
dev_err(dev, "failed to get sync: %d\n", err); dev_err(dev, "failed to get sync: %d\n", err);
return err; return err;