net: make ndo_get_stats64 a void function
The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to have a void function. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
63c64de7be
commit
bc1f44709c
@@ -1446,9 +1446,9 @@ static void xgmac_poll_controller(struct net_device *dev)
|
||||
}
|
||||
#endif
|
||||
|
||||
static struct rtnl_link_stats64 *
|
||||
static void
|
||||
xgmac_get_stats64(struct net_device *dev,
|
||||
struct rtnl_link_stats64 *storage)
|
||||
struct rtnl_link_stats64 *storage)
|
||||
{
|
||||
struct xgmac_priv *priv = netdev_priv(dev);
|
||||
void __iomem *base = priv->base;
|
||||
@@ -1476,7 +1476,6 @@ xgmac_get_stats64(struct net_device *dev,
|
||||
|
||||
writel(0, base + XGMAC_MMC_CTRL);
|
||||
spin_unlock_bh(&priv->stats_lock);
|
||||
return storage;
|
||||
}
|
||||
|
||||
static int xgmac_set_mac_address(struct net_device *dev, void *p)
|
||||
|
Reference in New Issue
Block a user