xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: make ndo_get_stats64 a void function

Browse Source 
The network device operation for reading statistics is only called
in one place, and it ignores the return value. Having a structure
return value is potentially confusing because some future driver could
incorrectly assume that the return value was used.

Fix all drivers with ndo_get_stats64 to have a void function.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
stephen hemminger
2017-01-06 19:12:52 -08:00
committed by David S. Miller
parent 63c64de7be
commit bc1f44709c
82 changed files with 166 additions and 309 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/alacritech/slicoss.c
View File

@@ -1471,8 +1471,8 @@ drop_skb:
return NETDEV_TX_OK;
}
static struct rtnl_link_stats64 *slic_get_stats(struct net_device *dev,
struct rtnl_link_stats64 *lst)
static void slic_get_stats(struct net_device *dev,
struct rtnl_link_stats64 *lst)
{
struct slic_device *sdev = netdev_priv(dev);
struct slic_stats *stats = &sdev->stats;
@@ -1489,8 +1489,6 @@ static struct rtnl_link_stats64 *slic_get_stats(struct net_device *dev,
SLIC_GET_STATS_COUNTER(lst->rx_crc_errors, stats, rx_crc);
SLIC_GET_STATS_COUNTER(lst->rx_fifo_errors, stats, rx_oflow802);
SLIC_GET_STATS_COUNTER(lst->tx_carrier_errors, stats, tx_carrier);
return lst;
}
static int slic_get_sset_count(struct net_device *dev, int sset)