virtio-gpu: switch to atomic cursor interfaces
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
@@ -38,6 +38,10 @@ static const uint32_t virtio_gpu_formats[] = {
|
||||
DRM_FORMAT_ABGR8888,
|
||||
};
|
||||
|
||||
static const uint32_t virtio_gpu_cursor_formats[] = {
|
||||
DRM_FORMAT_ARGB8888,
|
||||
};
|
||||
|
||||
static void virtio_gpu_plane_destroy(struct drm_plane *plane)
|
||||
{
|
||||
kfree(plane);
|
||||
@@ -58,8 +62,8 @@ static int virtio_gpu_plane_atomic_check(struct drm_plane *plane,
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void virtio_gpu_plane_atomic_update(struct drm_plane *plane,
|
||||
struct drm_plane_state *old_state)
|
||||
static void virtio_gpu_primary_plane_update(struct drm_plane *plane,
|
||||
struct drm_plane_state *old_state)
|
||||
{
|
||||
struct drm_device *dev = plane->dev;
|
||||
struct virtio_gpu_device *vgdev = dev->dev_private;
|
||||
@@ -104,32 +108,115 @@ static void virtio_gpu_plane_atomic_update(struct drm_plane *plane,
|
||||
plane->state->crtc_h);
|
||||
}
|
||||
|
||||
static void virtio_gpu_cursor_plane_update(struct drm_plane *plane,
|
||||
struct drm_plane_state *old_state)
|
||||
{
|
||||
struct drm_device *dev = plane->dev;
|
||||
struct virtio_gpu_device *vgdev = dev->dev_private;
|
||||
struct virtio_gpu_output *output = NULL;
|
||||
struct virtio_gpu_framebuffer *vgfb;
|
||||
struct virtio_gpu_fence *fence = NULL;
|
||||
struct virtio_gpu_object *bo = NULL;
|
||||
uint32_t handle;
|
||||
int ret = 0;
|
||||
|
||||
static const struct drm_plane_helper_funcs virtio_gpu_plane_helper_funcs = {
|
||||
if (plane->state->crtc)
|
||||
output = drm_crtc_to_virtio_gpu_output(plane->state->crtc);
|
||||
if (old_state->crtc)
|
||||
output = drm_crtc_to_virtio_gpu_output(old_state->crtc);
|
||||
WARN_ON(!output);
|
||||
|
||||
if (plane->state->fb) {
|
||||
vgfb = to_virtio_gpu_framebuffer(plane->state->fb);
|
||||
bo = gem_to_virtio_gpu_obj(vgfb->obj);
|
||||
handle = bo->hw_res_handle;
|
||||
} else {
|
||||
handle = 0;
|
||||
}
|
||||
|
||||
if (bo && bo->dumb && (plane->state->fb != old_state->fb)) {
|
||||
/* new cursor -- update & wait */
|
||||
virtio_gpu_cmd_transfer_to_host_2d
|
||||
(vgdev, handle, 0,
|
||||
cpu_to_le32(plane->state->crtc_w),
|
||||
cpu_to_le32(plane->state->crtc_h),
|
||||
0, 0, &fence);
|
||||
ret = virtio_gpu_object_reserve(bo, false);
|
||||
if (!ret) {
|
||||
reservation_object_add_excl_fence(bo->tbo.resv,
|
||||
&fence->f);
|
||||
fence_put(&fence->f);
|
||||
fence = NULL;
|
||||
virtio_gpu_object_unreserve(bo);
|
||||
virtio_gpu_object_wait(bo, false);
|
||||
}
|
||||
}
|
||||
|
||||
if (plane->state->fb != old_state->fb) {
|
||||
DRM_DEBUG("update, handle %d, +%d+%d\n", handle,
|
||||
plane->state->crtc_x,
|
||||
plane->state->crtc_y);
|
||||
output->cursor.hdr.type =
|
||||
cpu_to_le32(VIRTIO_GPU_CMD_UPDATE_CURSOR);
|
||||
output->cursor.resource_id = cpu_to_le32(handle);
|
||||
#if 0
|
||||
/* TODO */
|
||||
output->cursor.hot_x = cpu_to_le32(hot_x);
|
||||
output->cursor.hot_y = cpu_to_le32(hot_y);
|
||||
#endif
|
||||
} else {
|
||||
DRM_DEBUG("move +%d+%d\n",
|
||||
plane->state->crtc_x,
|
||||
plane->state->crtc_y);
|
||||
output->cursor.hdr.type =
|
||||
cpu_to_le32(VIRTIO_GPU_CMD_MOVE_CURSOR);
|
||||
}
|
||||
output->cursor.pos.x = cpu_to_le32(plane->state->crtc_x);
|
||||
output->cursor.pos.y = cpu_to_le32(plane->state->crtc_y);
|
||||
virtio_gpu_cursor_ping(vgdev, output);
|
||||
}
|
||||
|
||||
static const struct drm_plane_helper_funcs virtio_gpu_primary_helper_funcs = {
|
||||
.atomic_check = virtio_gpu_plane_atomic_check,
|
||||
.atomic_update = virtio_gpu_plane_atomic_update,
|
||||
.atomic_update = virtio_gpu_primary_plane_update,
|
||||
};
|
||||
|
||||
static const struct drm_plane_helper_funcs virtio_gpu_cursor_helper_funcs = {
|
||||
.atomic_check = virtio_gpu_plane_atomic_check,
|
||||
.atomic_update = virtio_gpu_cursor_plane_update,
|
||||
};
|
||||
|
||||
struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
|
||||
enum drm_plane_type type,
|
||||
int index)
|
||||
{
|
||||
struct drm_device *dev = vgdev->ddev;
|
||||
const struct drm_plane_helper_funcs *funcs;
|
||||
struct drm_plane *plane;
|
||||
int ret;
|
||||
const uint32_t *formats;
|
||||
int ret, nformats;
|
||||
|
||||
plane = kzalloc(sizeof(*plane), GFP_KERNEL);
|
||||
if (!plane)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
if (type == DRM_PLANE_TYPE_CURSOR) {
|
||||
formats = virtio_gpu_cursor_formats;
|
||||
nformats = ARRAY_SIZE(virtio_gpu_cursor_formats);
|
||||
funcs = &virtio_gpu_cursor_helper_funcs;
|
||||
} else {
|
||||
formats = virtio_gpu_formats;
|
||||
nformats = ARRAY_SIZE(virtio_gpu_formats);
|
||||
funcs = &virtio_gpu_primary_helper_funcs;
|
||||
}
|
||||
ret = drm_universal_plane_init(dev, plane, 1 << index,
|
||||
&virtio_gpu_plane_funcs,
|
||||
virtio_gpu_formats,
|
||||
ARRAY_SIZE(virtio_gpu_formats),
|
||||
DRM_PLANE_TYPE_PRIMARY, NULL);
|
||||
formats, nformats,
|
||||
type, NULL);
|
||||
if (ret)
|
||||
goto err_plane_init;
|
||||
|
||||
drm_plane_helper_add(plane, &virtio_gpu_plane_helper_funcs);
|
||||
drm_plane_helper_add(plane, funcs);
|
||||
return plane;
|
||||
|
||||
err_plane_init:
|
||||
|
Reference in New Issue
Block a user