percpu: use DEFINE_PER_CPU_SHARED_ALIGNED()
There are a few places where ___cacheline_aligned* is used with DEFINE_PER_CPU(). Use DEFINE_PER_CPU_SHARED_ALIGNED() instead. DEFINE_PER_CPU_SHARED_ALIGNED() applies alignment only on SMPs. While all other converted places used _in_smp variant or only get compiled for SMP, net/rds used unconditional ____cacheline_aligned. I don't see any reason these data structures should be aligned on UP and thus converted together. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Mike Frysinger <vapier@gentoo.org> Cc: Tony Luck <tony.luck@intel.com> Cc: Andy Grover <andy.grover@oracle.com>
This commit is contained in:
@@ -37,7 +37,7 @@
|
||||
#include "rds.h"
|
||||
#include "ib.h"
|
||||
|
||||
DEFINE_PER_CPU(struct rds_ib_statistics, rds_ib_stats) ____cacheline_aligned;
|
||||
DEFINE_PER_CPU_SHARED_ALIGNED(struct rds_ib_statistics, rds_ib_stats);
|
||||
|
||||
static char *rds_ib_stat_names[] = {
|
||||
"ib_connect_raced",
|
||||
|
@@ -37,7 +37,7 @@
|
||||
#include "rds.h"
|
||||
#include "iw.h"
|
||||
|
||||
DEFINE_PER_CPU(struct rds_iw_statistics, rds_iw_stats) ____cacheline_aligned;
|
||||
DEFINE_PER_CPU_SHARED_ALIGNED(struct rds_iw_statistics, rds_iw_stats);
|
||||
|
||||
static char *rds_iw_stat_names[] = {
|
||||
"iw_connect_raced",
|
||||
|
@@ -39,7 +39,7 @@ struct rds_page_remainder {
|
||||
unsigned long r_offset;
|
||||
};
|
||||
|
||||
DEFINE_PER_CPU(struct rds_page_remainder, rds_page_remainders) ____cacheline_aligned;
|
||||
DEFINE_PER_CPU_SHARED_ALIGNED(struct rds_page_remainder, rds_page_remainders);
|
||||
|
||||
/*
|
||||
* returns 0 on success or -errno on failure.
|
||||
|
Reference in New Issue
Block a user