xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: eeprom: assignment outside the if statement

Browse Source 
Assignment of any variable should be kept outside the if statement

Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Parth Y Shah
2018-08-03 14:50:43 +05:30
committed by Greg Kroah-Hartman
parent f019f07ecf
commit b83a4141f0
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/misc/eeprom/max6875.c
View File

@@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client,
if (client->addr & 1) if (client->addr & 1)
return -ENODEV; return -ENODEV;
if (!(data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL))) data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL);
if (!data)
return -ENOMEM; return -ENOMEM;
/* A fake client is created on the odd address */ /* A fake client is created on the odd address */