net: Make setsockopt() optlen be unsigned.
This provides safety against negative optlen at the type level instead of depending upon (sometimes non-trivial) checks against this sprinkled all over the the place, in each and every implementation. Based upon work done by Arjan van de Ven and feedback from Linus Torvalds. Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
@@ -1359,7 +1359,7 @@ void udp_destroy_sock(struct sock *sk)
|
||||
* Socket option code for UDP
|
||||
*/
|
||||
int udp_lib_setsockopt(struct sock *sk, int level, int optname,
|
||||
char __user *optval, int optlen,
|
||||
char __user *optval, unsigned int optlen,
|
||||
int (*push_pending_frames)(struct sock *))
|
||||
{
|
||||
struct udp_sock *up = udp_sk(sk);
|
||||
@@ -1441,7 +1441,7 @@ int udp_lib_setsockopt(struct sock *sk, int level, int optname,
|
||||
EXPORT_SYMBOL(udp_lib_setsockopt);
|
||||
|
||||
int udp_setsockopt(struct sock *sk, int level, int optname,
|
||||
char __user *optval, int optlen)
|
||||
char __user *optval, unsigned int optlen)
|
||||
{
|
||||
if (level == SOL_UDP || level == SOL_UDPLITE)
|
||||
return udp_lib_setsockopt(sk, level, optname, optval, optlen,
|
||||
@@ -1451,7 +1451,7 @@ int udp_setsockopt(struct sock *sk, int level, int optname,
|
||||
|
||||
#ifdef CONFIG_COMPAT
|
||||
int compat_udp_setsockopt(struct sock *sk, int level, int optname,
|
||||
char __user *optval, int optlen)
|
||||
char __user *optval, unsigned int optlen)
|
||||
{
|
||||
if (level == SOL_UDP || level == SOL_UDPLITE)
|
||||
return udp_lib_setsockopt(sk, level, optname, optval, optlen,
|
||||
|
Reference in New Issue
Block a user