clk: ti: dpll: convert DPLL support code to use clk_hw instead of clk ptrs
Convert DPLL support code to use clk_hw pointers for reference and bypass clocks. This allows us to use clk_hw_* APIs for accessing any required parameters for these clocks, avoiding some locking problems at least with DPLL enable code; this used clk_get_rate which uses mutex but isn't good under clk_enable / clk_disable. Signed-off-by: Tero Kristo <t-kristo@ti.com> Acked-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:

committed by
Stephen Boyd

parent
1e59403990
commit
b6f5128459
@@ -147,11 +147,9 @@ static void __init _register_dpll(struct clk_hw *hw,
|
||||
struct dpll_data *dd = clk_hw->dpll_data;
|
||||
struct clk *clk;
|
||||
|
||||
dd->clk_ref = of_clk_get(node, 0);
|
||||
dd->clk_bypass = of_clk_get(node, 1);
|
||||
|
||||
if (IS_ERR(dd->clk_ref) || IS_ERR(dd->clk_bypass)) {
|
||||
pr_debug("clk-ref or clk-bypass missing for %s, retry later\n",
|
||||
clk = of_clk_get(node, 0);
|
||||
if (IS_ERR(clk)) {
|
||||
pr_debug("clk-ref missing for %s, retry later\n",
|
||||
node->name);
|
||||
if (!ti_clk_retry_init(node, hw, _register_dpll))
|
||||
return;
|
||||
@@ -159,6 +157,21 @@ static void __init _register_dpll(struct clk_hw *hw,
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
dd->clk_ref = __clk_get_hw(clk);
|
||||
|
||||
clk = of_clk_get(node, 1);
|
||||
|
||||
if (IS_ERR(clk)) {
|
||||
pr_debug("clk-bypass missing for %s, retry later\n",
|
||||
node->name);
|
||||
if (!ti_clk_retry_init(node, hw, _register_dpll))
|
||||
return;
|
||||
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
dd->clk_bypass = __clk_get_hw(clk);
|
||||
|
||||
/* register the clock */
|
||||
clk = clk_register(NULL, &clk_hw->hw);
|
||||
|
||||
@@ -251,8 +264,8 @@ struct clk *ti_clk_register_dpll(struct ti_clk *setup)
|
||||
dd->recal_en_bit = dpll->recal_en_bit;
|
||||
dd->recal_st_bit = dpll->recal_st_bit;
|
||||
|
||||
dd->clk_ref = clk_ref;
|
||||
dd->clk_bypass = clk_bypass;
|
||||
dd->clk_ref = __clk_get_hw(clk_ref);
|
||||
dd->clk_bypass = __clk_get_hw(clk_bypass);
|
||||
|
||||
if (dpll->flags & CLKF_CORE)
|
||||
ops = &omap3_dpll_core_ck_ops;
|
||||
|
Reference in New Issue
Block a user