clk: ti: dpll: convert DPLL support code to use clk_hw instead of clk ptrs
Convert DPLL support code to use clk_hw pointers for reference and bypass clocks. This allows us to use clk_hw_* APIs for accessing any required parameters for these clocks, avoiding some locking problems at least with DPLL enable code; this used clk_get_rate which uses mutex but isn't good under clk_enable / clk_disable. Signed-off-by: Tero Kristo <t-kristo@ti.com> Acked-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:

committad av
Stephen Boyd

förälder
1e59403990
incheckning
b6f5128459
@@ -140,11 +140,9 @@ static void __init omap_clk_register_apll(struct clk_hw *hw,
|
||||
struct dpll_data *ad = clk_hw->dpll_data;
|
||||
struct clk *clk;
|
||||
|
||||
ad->clk_ref = of_clk_get(node, 0);
|
||||
ad->clk_bypass = of_clk_get(node, 1);
|
||||
|
||||
if (IS_ERR(ad->clk_ref) || IS_ERR(ad->clk_bypass)) {
|
||||
pr_debug("clk-ref or clk-bypass for %s not ready, retry\n",
|
||||
clk = of_clk_get(node, 0);
|
||||
if (IS_ERR(clk)) {
|
||||
pr_debug("clk-ref for %s not ready, retry\n",
|
||||
node->name);
|
||||
if (!ti_clk_retry_init(node, hw, omap_clk_register_apll))
|
||||
return;
|
||||
@@ -152,6 +150,20 @@ static void __init omap_clk_register_apll(struct clk_hw *hw,
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
ad->clk_ref = __clk_get_hw(clk);
|
||||
|
||||
clk = of_clk_get(node, 1);
|
||||
if (IS_ERR(clk)) {
|
||||
pr_debug("clk-bypass for %s not ready, retry\n",
|
||||
node->name);
|
||||
if (!ti_clk_retry_init(node, hw, omap_clk_register_apll))
|
||||
return;
|
||||
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
ad->clk_bypass = __clk_get_hw(clk);
|
||||
|
||||
clk = clk_register(NULL, &clk_hw->hw);
|
||||
if (!IS_ERR(clk)) {
|
||||
of_clk_add_provider(node, of_clk_src_simple_get, clk);
|
||||
|
Referens i nytt ärende
Block a user