[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of structures in order to not have to document their locking. One of these structures was a struct tty_operations. In order to const it in UML without introducing compiler complaints, the declaration of tty_set_operations needs to be changed, and then all of its callers need to be fixed. This patch declares all struct tty_operations in the tree as const. In all cases, they are static and used only as input to tty_set_operations. As an extra check, I ran an i386 allyesconfig build which produced no extra warnings. 53 drivers are affected. I checked the history of a bunch of them, and in most cases, there have been only a handful of maintenance changes in the last six months. serial_core.c was the busiest one that I looked at. Signed-off-by: Jeff Dike <jdike@addtoit.com> Acked-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:

committed by
Linus Torvalds

parent
ed97bd37ef
commit
b68e31d0eb
@@ -1378,7 +1378,7 @@ void startup_console(void)
|
||||
#endif /* CONFIG_PM_LEGACY */
|
||||
|
||||
|
||||
static struct tty_operations rs_ops = {
|
||||
static const struct tty_operations rs_ops = {
|
||||
.open = rs_open,
|
||||
.close = rs_close,
|
||||
.write = rs_write,
|
||||
|
@@ -2424,7 +2424,7 @@ long console_360_init(long kmem_start, long kmem_end)
|
||||
*/
|
||||
static int baud_idx;
|
||||
|
||||
static struct tty_operations rs_360_ops = {
|
||||
static const struct tty_operations rs_360_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.open = rs_360_open,
|
||||
.close = rs_360_close,
|
||||
|
@@ -4825,7 +4825,7 @@ show_serial_version(void)
|
||||
|
||||
/* rs_init inits the driver at boot (using the module_init chain) */
|
||||
|
||||
static struct tty_operations rs_ops = {
|
||||
static const struct tty_operations rs_ops = {
|
||||
.open = rs_open,
|
||||
.close = rs_close,
|
||||
.write = rs_write,
|
||||
|
@@ -1666,7 +1666,7 @@ static void show_serial_version(void)
|
||||
printk(mcfrs_drivername);
|
||||
}
|
||||
|
||||
static struct tty_operations mcfrs_ops = {
|
||||
static const struct tty_operations mcfrs_ops = {
|
||||
.open = mcfrs_open,
|
||||
.close = mcfrs_close,
|
||||
.write = mcfrs_write,
|
||||
|
@@ -2111,7 +2111,7 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
|
||||
}
|
||||
}
|
||||
|
||||
static struct tty_operations uart_ops = {
|
||||
static const struct tty_operations uart_ops = {
|
||||
.open = uart_open,
|
||||
.close = uart_close,
|
||||
.write = uart_write,
|
||||
|
Reference in New Issue
Block a user