xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] omap3isp: remove per ISP module link creation functions

Browse Source 
The entities to video nodes links were created on separate functions for
each ISP module but since the only thing that these functions do is to
call media_create_pad_link(), there's no need for that indirection level
and all link creation logic can be just inlined in the caller function.

Also, since the only possible failure for the link creation is a memory
allocation, there is no need for error messages since the core already
reports a very verbose message in that case.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Javier Martinez Canillas
2015-12-11 15:16:27 -02:00
committed by Mauro Carvalho Chehab
parent b3b7a9f138
commit b5f6df0607
11 changed files with 35 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/media/platform/omap3isp/ispccp2.c
View File

@@ -1153,20 +1153,6 @@ int omap3isp_ccp2_init(struct isp_device *isp)
return 0;
}
/*
* omap3isp_ccp2_create_pads_links - CCP2 pads links creation
* @isp : Pointer to ISP device
* return negative error code or zero on success
*/
int omap3isp_ccp2_create_pads_links(struct isp_device *isp)
{
struct isp_ccp2_device *ccp2 = &isp->isp_ccp2;
/* Connect the video node to the ccp2 subdev. */
return media_create_pad_link(&ccp2->video_in.video.entity, 0,
&ccp2->subdev.entity, CCP2_PAD_SINK, 0);
}
/*
* omap3isp_ccp2_cleanup - CCP2 un-initialization
* @isp : Pointer to ISP device