xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging:iio:adc:ad7280a: Fix handing of device address bit reversing.

Browse Source 
[ Upstream commit f281e4ddbbc0b60f061bc18a2834e9363ba85f9f ]

The bit reversal was wrong for bits 1 and 3 of the 5 bits.
Result is driver failure to probe if you have more than 2 daisy-chained
devices.  Discovered via QEMU based device emulation.

Fixes tag is for when this moved from a macro to a function, but it
was broken before that.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: 065a7c0b1f ("Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse")
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Link: https://lore.kernel.org/r/20220206190328.333093-2-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jonathan Cameron
2022-02-06 19:03:09 +00:00
committed by Greg Kroah-Hartman
parent f5b01abf5f
commit b5db33a81e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/iio/adc/ad7280a.c
View File

@@ -107,9 +107,9 @@
static unsigned int ad7280a_devaddr(unsigned int addr) static unsigned int ad7280a_devaddr(unsigned int addr)
{ {
return ((addr & 0x1) << 4) | return ((addr & 0x1) << 4) |
((addr & 0x2) << 3) | ((addr & 0x2) << 2) |
(addr & 0x4) | (addr & 0x4) |
((addr & 0x8) >> 3) | ((addr & 0x8) >> 2) |
((addr & 0x10) >> 4); ((addr & 0x10) >> 4);
} }