net/tls: don't clear TX resync flag on error
Introduce a return code for the tls_dev_resync callback. When the driver TX resync fails, kernel can retry the resync again until it succeeds. This prevents drivers from attempting to offload TLS packets if the connection is known to be out of sync. We don't worry about the RX resync since they will be retried naturally as more encrypted records get received. Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
427545b304
commit
b5d9a834f4
@@ -214,6 +214,7 @@ static void tls_device_resync_tx(struct sock *sk, struct tls_context *tls_ctx,
|
||||
{
|
||||
struct net_device *netdev;
|
||||
struct sk_buff *skb;
|
||||
int err = 0;
|
||||
u8 *rcd_sn;
|
||||
|
||||
skb = tcp_write_queue_tail(sk);
|
||||
@@ -225,9 +226,12 @@ static void tls_device_resync_tx(struct sock *sk, struct tls_context *tls_ctx,
|
||||
down_read(&device_offload_lock);
|
||||
netdev = tls_ctx->netdev;
|
||||
if (netdev)
|
||||
netdev->tlsdev_ops->tls_dev_resync(netdev, sk, seq, rcd_sn,
|
||||
TLS_OFFLOAD_CTX_DIR_TX);
|
||||
err = netdev->tlsdev_ops->tls_dev_resync(netdev, sk, seq,
|
||||
rcd_sn,
|
||||
TLS_OFFLOAD_CTX_DIR_TX);
|
||||
up_read(&device_offload_lock);
|
||||
if (err)
|
||||
return;
|
||||
|
||||
clear_bit_unlock(TLS_TX_SYNC_SCHED, &tls_ctx->flags);
|
||||
}
|
||||
|
Reference in New Issue
Block a user