[media] cx88: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:

committed by
Mauro Carvalho Chehab

parent
01a5cbebce
commit
b52377475a
@@ -139,8 +139,7 @@ int cx88_i2c_init(struct cx88_core *core, struct pci_dev *pci)
|
||||
if (i2c_udelay<5)
|
||||
i2c_udelay=5;
|
||||
|
||||
memcpy(&core->i2c_algo, &cx8800_i2c_algo_template,
|
||||
sizeof(core->i2c_algo));
|
||||
core->i2c_algo = cx8800_i2c_algo_template;
|
||||
|
||||
|
||||
core->i2c_adap.dev.parent = &pci->dev;
|
||||
|
Reference in New Issue
Block a user