cfg80211: clear connect keys when freeing them
When freeing the connect keys, clear the memory to avoid having the key material stick around in memory "forever". Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
@@ -6866,7 +6866,7 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
|
||||
|
||||
err = cfg80211_join_ibss(rdev, dev, &ibss, connkeys);
|
||||
if (err)
|
||||
kfree(connkeys);
|
||||
kzfree(connkeys);
|
||||
return err;
|
||||
}
|
||||
|
||||
@@ -7235,7 +7235,7 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info)
|
||||
|
||||
if (info->attrs[NL80211_ATTR_HT_CAPABILITY]) {
|
||||
if (!info->attrs[NL80211_ATTR_HT_CAPABILITY_MASK]) {
|
||||
kfree(connkeys);
|
||||
kzfree(connkeys);
|
||||
return -EINVAL;
|
||||
}
|
||||
memcpy(&connect.ht_capa,
|
||||
@@ -7253,7 +7253,7 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info)
|
||||
|
||||
if (info->attrs[NL80211_ATTR_VHT_CAPABILITY]) {
|
||||
if (!info->attrs[NL80211_ATTR_VHT_CAPABILITY_MASK]) {
|
||||
kfree(connkeys);
|
||||
kzfree(connkeys);
|
||||
return -EINVAL;
|
||||
}
|
||||
memcpy(&connect.vht_capa,
|
||||
@@ -7273,7 +7273,7 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info)
|
||||
err = cfg80211_connect(rdev, dev, &connect, connkeys, NULL);
|
||||
wdev_unlock(dev->ieee80211_ptr);
|
||||
if (err)
|
||||
kfree(connkeys);
|
||||
kzfree(connkeys);
|
||||
return err;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user