xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA/cm: Fix memory leak in ib_cm_insert_listen

Browse Source 
commit 2990f223ffa7bb25422956b9f79f9176a5b38346 upstream.

cm_alloc_id_priv() allocates resource for the cm_id_priv. When
cm_init_listen() fails it doesn't free it, leading to memory leak.

Add the missing error unwind.

Fixes: 98f67156a8 ("RDMA/cm: Simplify establishing a listen cm_id")
Link: https://lore.kernel.org/r/20220621052546.4821-1-linmq006@gmail.com
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Miaoqian Lin
2022-06-21 09:25:44 +04:00
committed by Greg Kroah-Hartman
parent 9de276dfb2
commit b0cab8b517
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/core/cm.c
View File

@@ -1280,8 +1280,10 @@ struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device,
return ERR_CAST(cm_id_priv); return ERR_CAST(cm_id_priv);
err = cm_init_listen(cm_id_priv, service_id, 0); err = cm_init_listen(cm_id_priv, service_id, 0);
if (err) if (err) {
ib_destroy_cm_id(&cm_id_priv->id);
return ERR_PTR(err); return ERR_PTR(err);
}
spin_lock_irq(&cm_id_priv->lock); spin_lock_irq(&cm_id_priv->lock);
listen_id_priv = cm_insert_listen(cm_id_priv, cm_handler); listen_id_priv = cm_insert_listen(cm_id_priv, cm_handler);