Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
Pull more overflow updates from Kees Cook: "The rest of the overflow changes for v4.18-rc1. This includes the explicit overflow fixes from Silvio, further struct_size() conversions from Matthew, and a bug fix from Dan. But the bulk of it is the treewide conversions to use either the 2-factor argument allocators (e.g. kmalloc(a * b, ...) into kmalloc_array(a, b, ...) or the array_size() macros (e.g. vmalloc(a * b) into vmalloc(array_size(a, b)). Coccinelle was fighting me on several fronts, so I've done a bunch of manual whitespace updates in the patches as well. Summary: - Error path bug fix for overflow tests (Dan) - Additional struct_size() conversions (Matthew, Kees) - Explicitly reported overflow fixes (Silvio, Kees) - Add missing kvcalloc() function (Kees) - Treewide conversions of allocators to use either 2-factor argument variant when available, or array_size() and array3_size() as needed (Kees)" * tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux: (26 commits) treewide: Use array_size in f2fs_kvzalloc() treewide: Use array_size() in f2fs_kzalloc() treewide: Use array_size() in f2fs_kmalloc() treewide: Use array_size() in sock_kmalloc() treewide: Use array_size() in kvzalloc_node() treewide: Use array_size() in vzalloc_node() treewide: Use array_size() in vzalloc() treewide: Use array_size() in vmalloc() treewide: devm_kzalloc() -> devm_kcalloc() treewide: devm_kmalloc() -> devm_kmalloc_array() treewide: kvzalloc() -> kvcalloc() treewide: kvmalloc() -> kvmalloc_array() treewide: kzalloc_node() -> kcalloc_node() treewide: kzalloc() -> kcalloc() treewide: kmalloc() -> kmalloc_array() mm: Introduce kvcalloc() video: uvesafb: Fix integer overflow in allocation UBIFS: Fix potential integer overflow in allocation leds: Use struct_size() in allocation Convert intel uncore to struct_size ...
This commit is contained in:
@@ -890,7 +890,7 @@ static int scpi_alloc_xfer_list(struct device *dev, struct scpi_chan *ch)
|
||||
int i;
|
||||
struct scpi_xfer *xfers;
|
||||
|
||||
xfers = devm_kzalloc(dev, MAX_SCPI_XFERS * sizeof(*xfers), GFP_KERNEL);
|
||||
xfers = devm_kcalloc(dev, MAX_SCPI_XFERS, sizeof(*xfers), GFP_KERNEL);
|
||||
if (!xfers)
|
||||
return -ENOMEM;
|
||||
|
||||
|
@@ -146,7 +146,7 @@ static int create_packet(void *data, size_t length)
|
||||
packet_array_size = max(
|
||||
(unsigned int)(allocation_floor / rbu_data.packetsize),
|
||||
(unsigned int)1);
|
||||
invalid_addr_packet_array = kzalloc(packet_array_size * sizeof(void*),
|
||||
invalid_addr_packet_array = kcalloc(packet_array_size, sizeof(void *),
|
||||
GFP_KERNEL);
|
||||
|
||||
if (!invalid_addr_packet_array) {
|
||||
|
@@ -231,7 +231,7 @@ int efi_capsule_update(efi_capsule_header_t *capsule, phys_addr_t *pages)
|
||||
count = DIV_ROUND_UP(imagesize, PAGE_SIZE);
|
||||
sg_count = sg_pages_num(count);
|
||||
|
||||
sg_pages = kzalloc(sg_count * sizeof(*sg_pages), GFP_KERNEL);
|
||||
sg_pages = kcalloc(sg_count, sizeof(*sg_pages), GFP_KERNEL);
|
||||
if (!sg_pages)
|
||||
return -ENOMEM;
|
||||
|
||||
|
@@ -166,7 +166,7 @@ int __init efi_runtime_map_init(struct kobject *efi_kobj)
|
||||
if (!efi_enabled(EFI_MEMMAP))
|
||||
return 0;
|
||||
|
||||
map_entries = kzalloc(efi.memmap.nr_map * sizeof(entry), GFP_KERNEL);
|
||||
map_entries = kcalloc(efi.memmap.nr_map, sizeof(entry), GFP_KERNEL);
|
||||
if (!map_entries) {
|
||||
ret = -ENOMEM;
|
||||
goto out;
|
||||
|
@@ -1854,9 +1854,9 @@ static int ti_sci_probe(struct platform_device *pdev)
|
||||
if (!minfo->xfer_block)
|
||||
return -ENOMEM;
|
||||
|
||||
minfo->xfer_alloc_table = devm_kzalloc(dev,
|
||||
BITS_TO_LONGS(desc->max_msgs)
|
||||
* sizeof(unsigned long),
|
||||
minfo->xfer_alloc_table = devm_kcalloc(dev,
|
||||
BITS_TO_LONGS(desc->max_msgs),
|
||||
sizeof(unsigned long),
|
||||
GFP_KERNEL);
|
||||
if (!minfo->xfer_alloc_table)
|
||||
return -ENOMEM;
|
||||
|
Reference in New Issue
Block a user