ANDROID: vfs: add d_canonical_path for stacked filesystem support
Inotify does not currently know when a filesystem is acting as a wrapper around another fs. This means that inotify watchers will miss any modifications to the base file, as well as any made in a separate stacked fs that points to the same file. d_canonical_path solves this problem by allowing the fs to map a dentry to a path in the lower fs. Inotify can use it to find the appropriate place to watch to be informed of all changes to a file. Test: HiKey/X15 + Pie + android-mainline, and HiKey + AOSP Maser + android-mainline, directories under /sdcard created, output of mount is right, CTS test collecting device infor works Bug: 70706497 Change-Id: I09563baffad1711a045e45c1bd0bd8713c2cc0b6 Signed-off-by: Daniel Rosenberg <drosen@google.com> [astrachan: Folded 34df4102216e ("ANDROID: fsnotify: Notify lower fs of open") into this patch] Signed-off-by: Alistair Strachan <astrachan@google.com> Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
This commit is contained in:

committed by
Alistair Delva

parent
e2b3aa25c5
commit
b05bef535d
@@ -236,6 +236,7 @@ static inline void fsnotify_modify(struct file *file)
|
||||
static inline void fsnotify_open(struct file *file)
|
||||
{
|
||||
const struct path *path = &file->f_path;
|
||||
struct path lower_path;
|
||||
struct inode *inode = file_inode(file);
|
||||
__u32 mask = FS_OPEN;
|
||||
|
||||
@@ -244,6 +245,12 @@ static inline void fsnotify_open(struct file *file)
|
||||
if (file->f_flags & __FMODE_EXEC)
|
||||
mask |= FS_OPEN_EXEC;
|
||||
|
||||
if (path->dentry->d_op && path->dentry->d_op->d_canonical_path) {
|
||||
path->dentry->d_op->d_canonical_path(path, &lower_path);
|
||||
fsnotify_parent(&lower_path, NULL, mask);
|
||||
fsnotify(lower_path.dentry->d_inode, mask, &lower_path, FSNOTIFY_EVENT_PATH, NULL, 0);
|
||||
path_put(&lower_path);
|
||||
}
|
||||
fsnotify_path(inode, path, mask);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user