Remove "unsafe" from module struct
Adrian Bunk points out that "unsafe" was used to mark modules touched by the deprecated MOD_INC_USE_COUNT interface, which has long gone. It's time to remove the member from the module structure, as well. If you want a module which can't unload, don't register an exit function. (Vlad Yasevich says SCTP is now safe to unload, so just remove the __unsafe there). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Acked-by: Shannon Nelson <shannon.nelson@intel.com> Acked-by: Dan Williams <dan.j.williams@intel.com> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com> Cc: Sridhar Samudrala <sri@us.ibm.com> Cc: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Этот коммит содержится в:

коммит произвёл
Linus Torvalds

родитель
d9c9bef134
Коммит
af49d9248f
@@ -1446,21 +1446,20 @@ static struct platform_driver iop_adma_driver = {
|
||||
|
||||
static int __init iop_adma_init (void)
|
||||
{
|
||||
/* it's currently unsafe to unload this module */
|
||||
/* if forced, worst case is that rmmod hangs */
|
||||
__unsafe(THIS_MODULE);
|
||||
|
||||
return platform_driver_register(&iop_adma_driver);
|
||||
}
|
||||
|
||||
/* it's currently unsafe to unload this module */
|
||||
#if 0
|
||||
static void __exit iop_adma_exit (void)
|
||||
{
|
||||
platform_driver_unregister(&iop_adma_driver);
|
||||
return;
|
||||
}
|
||||
module_exit(iop_adma_exit);
|
||||
#endif
|
||||
|
||||
module_init(iop_adma_init);
|
||||
module_exit(iop_adma_exit);
|
||||
|
||||
MODULE_AUTHOR("Intel Corporation");
|
||||
MODULE_DESCRIPTION("IOP ADMA Engine Driver");
|
||||
|
Ссылка в новой задаче
Block a user