tty: move the termios object into the tty
This will let us sort out a whole pile of tty related races. The alternative would be to keep points and refcount the termios objects. However 1. They are tiny anyway 2. Many devices don't use the stored copies 3. We can remove a pty special case Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
6d31a88cb2
commit
adc8d746ca
@@ -873,7 +873,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
|
||||
|
||||
/* Handle transition to B0 status */
|
||||
if (old_termios->c_cflag & CBAUD &&
|
||||
!(tty->termios->c_cflag & CBAUD)) {
|
||||
!(tty->termios.c_cflag & CBAUD)) {
|
||||
info->serial_signals &= ~(SerialSignal_RTS + SerialSignal_DTR);
|
||||
spin_lock_irqsave(&info->lock,flags);
|
||||
set_signals(info);
|
||||
@@ -882,9 +882,9 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
|
||||
|
||||
/* Handle transition away from B0 status */
|
||||
if (!(old_termios->c_cflag & CBAUD) &&
|
||||
tty->termios->c_cflag & CBAUD) {
|
||||
tty->termios.c_cflag & CBAUD) {
|
||||
info->serial_signals |= SerialSignal_DTR;
|
||||
if (!(tty->termios->c_cflag & CRTSCTS) ||
|
||||
if (!(tty->termios.c_cflag & CRTSCTS) ||
|
||||
!test_bit(TTY_THROTTLED, &tty->flags)) {
|
||||
info->serial_signals |= SerialSignal_RTS;
|
||||
}
|
||||
@@ -895,7 +895,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
|
||||
|
||||
/* Handle turning off CRTSCTS */
|
||||
if (old_termios->c_cflag & CRTSCTS &&
|
||||
!(tty->termios->c_cflag & CRTSCTS)) {
|
||||
!(tty->termios.c_cflag & CRTSCTS)) {
|
||||
tty->hw_stopped = 0;
|
||||
tx_release(tty);
|
||||
}
|
||||
@@ -1473,7 +1473,7 @@ static void throttle(struct tty_struct * tty)
|
||||
if (I_IXOFF(tty))
|
||||
send_xchar(tty, STOP_CHAR(tty));
|
||||
|
||||
if (tty->termios->c_cflag & CRTSCTS) {
|
||||
if (tty->termios.c_cflag & CRTSCTS) {
|
||||
spin_lock_irqsave(&info->lock,flags);
|
||||
info->serial_signals &= ~SerialSignal_RTS;
|
||||
set_signals(info);
|
||||
@@ -1502,7 +1502,7 @@ static void unthrottle(struct tty_struct * tty)
|
||||
send_xchar(tty, START_CHAR(tty));
|
||||
}
|
||||
|
||||
if (tty->termios->c_cflag & CRTSCTS) {
|
||||
if (tty->termios.c_cflag & CRTSCTS) {
|
||||
spin_lock_irqsave(&info->lock,flags);
|
||||
info->serial_signals |= SerialSignal_RTS;
|
||||
set_signals(info);
|
||||
@@ -2708,7 +2708,7 @@ static void shutdown(SLMP_INFO * info)
|
||||
|
||||
reset_port(info);
|
||||
|
||||
if (!info->port.tty || info->port.tty->termios->c_cflag & HUPCL) {
|
||||
if (!info->port.tty || info->port.tty->termios.c_cflag & HUPCL) {
|
||||
info->serial_signals &= ~(SerialSignal_DTR + SerialSignal_RTS);
|
||||
set_signals(info);
|
||||
}
|
||||
@@ -2749,7 +2749,7 @@ static void program_hw(SLMP_INFO *info)
|
||||
|
||||
get_signals(info);
|
||||
|
||||
if (info->netcount || (info->port.tty && info->port.tty->termios->c_cflag & CREAD) )
|
||||
if (info->netcount || (info->port.tty && info->port.tty->termios.c_cflag & CREAD) )
|
||||
rx_start(info);
|
||||
|
||||
spin_unlock_irqrestore(&info->lock,flags);
|
||||
@@ -2762,14 +2762,14 @@ static void change_params(SLMP_INFO *info)
|
||||
unsigned cflag;
|
||||
int bits_per_char;
|
||||
|
||||
if (!info->port.tty || !info->port.tty->termios)
|
||||
if (!info->port.tty)
|
||||
return;
|
||||
|
||||
if (debug_level >= DEBUG_LEVEL_INFO)
|
||||
printk("%s(%d):%s change_params()\n",
|
||||
__FILE__,__LINE__, info->device_name );
|
||||
|
||||
cflag = info->port.tty->termios->c_cflag;
|
||||
cflag = info->port.tty->termios.c_cflag;
|
||||
|
||||
/* if B0 rate (hangup) specified then negate DTR and RTS */
|
||||
/* otherwise assert DTR and RTS */
|
||||
@@ -3306,7 +3306,7 @@ static int block_til_ready(struct tty_struct *tty, struct file *filp,
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (tty->termios->c_cflag & CLOCAL)
|
||||
if (tty->termios.c_cflag & CLOCAL)
|
||||
do_clocal = true;
|
||||
|
||||
/* Wait for carrier detect and the line to become
|
||||
@@ -3332,7 +3332,7 @@ static int block_til_ready(struct tty_struct *tty, struct file *filp,
|
||||
port->blocked_open++;
|
||||
|
||||
while (1) {
|
||||
if (tty->termios->c_cflag & CBAUD)
|
||||
if (tty->termios.c_cflag & CBAUD)
|
||||
tty_port_raise_dtr_rts(port);
|
||||
|
||||
set_current_state(TASK_INTERRUPTIBLE);
|
||||
|
Reference in New Issue
Block a user