tty: move the termios object into the tty
This will let us sort out a whole pile of tty related races. The alternative would be to keep points and refcount the termios objects. However 1. They are tiny anyway 2. Many devices don't use the stored copies 3. We can remove a pty special case Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
6d31a88cb2
commit
adc8d746ca
@@ -518,7 +518,7 @@ static void sdio_uart_check_modem_status(struct sdio_uart_port *port)
|
||||
if (status & UART_MSR_DCTS) {
|
||||
port->icount.cts++;
|
||||
tty = tty_port_tty_get(&port->port);
|
||||
if (tty && (tty->termios->c_cflag & CRTSCTS)) {
|
||||
if (tty && (tty->termios.c_cflag & CRTSCTS)) {
|
||||
int cts = (status & UART_MSR_CTS);
|
||||
if (tty->hw_stopped) {
|
||||
if (cts) {
|
||||
@@ -671,12 +671,12 @@ static int sdio_uart_activate(struct tty_port *tport, struct tty_struct *tty)
|
||||
port->ier = UART_IER_RLSI|UART_IER_RDI|UART_IER_RTOIE|UART_IER_UUE;
|
||||
port->mctrl = TIOCM_OUT2;
|
||||
|
||||
sdio_uart_change_speed(port, tty->termios, NULL);
|
||||
sdio_uart_change_speed(port, &tty->termios, NULL);
|
||||
|
||||
if (tty->termios->c_cflag & CBAUD)
|
||||
if (tty->termios.c_cflag & CBAUD)
|
||||
sdio_uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
|
||||
|
||||
if (tty->termios->c_cflag & CRTSCTS)
|
||||
if (tty->termios.c_cflag & CRTSCTS)
|
||||
if (!(sdio_uart_get_mctrl(port) & TIOCM_CTS))
|
||||
tty->hw_stopped = 1;
|
||||
|
||||
@@ -850,7 +850,7 @@ static void sdio_uart_throttle(struct tty_struct *tty)
|
||||
{
|
||||
struct sdio_uart_port *port = tty->driver_data;
|
||||
|
||||
if (!I_IXOFF(tty) && !(tty->termios->c_cflag & CRTSCTS))
|
||||
if (!I_IXOFF(tty) && !(tty->termios.c_cflag & CRTSCTS))
|
||||
return;
|
||||
|
||||
if (sdio_uart_claim_func(port) != 0)
|
||||
@@ -861,7 +861,7 @@ static void sdio_uart_throttle(struct tty_struct *tty)
|
||||
sdio_uart_start_tx(port);
|
||||
}
|
||||
|
||||
if (tty->termios->c_cflag & CRTSCTS)
|
||||
if (tty->termios.c_cflag & CRTSCTS)
|
||||
sdio_uart_clear_mctrl(port, TIOCM_RTS);
|
||||
|
||||
sdio_uart_irq(port->func);
|
||||
@@ -872,7 +872,7 @@ static void sdio_uart_unthrottle(struct tty_struct *tty)
|
||||
{
|
||||
struct sdio_uart_port *port = tty->driver_data;
|
||||
|
||||
if (!I_IXOFF(tty) && !(tty->termios->c_cflag & CRTSCTS))
|
||||
if (!I_IXOFF(tty) && !(tty->termios.c_cflag & CRTSCTS))
|
||||
return;
|
||||
|
||||
if (sdio_uart_claim_func(port) != 0)
|
||||
@@ -887,7 +887,7 @@ static void sdio_uart_unthrottle(struct tty_struct *tty)
|
||||
}
|
||||
}
|
||||
|
||||
if (tty->termios->c_cflag & CRTSCTS)
|
||||
if (tty->termios.c_cflag & CRTSCTS)
|
||||
sdio_uart_set_mctrl(port, TIOCM_RTS);
|
||||
|
||||
sdio_uart_irq(port->func);
|
||||
@@ -898,12 +898,12 @@ static void sdio_uart_set_termios(struct tty_struct *tty,
|
||||
struct ktermios *old_termios)
|
||||
{
|
||||
struct sdio_uart_port *port = tty->driver_data;
|
||||
unsigned int cflag = tty->termios->c_cflag;
|
||||
unsigned int cflag = tty->termios.c_cflag;
|
||||
|
||||
if (sdio_uart_claim_func(port) != 0)
|
||||
return;
|
||||
|
||||
sdio_uart_change_speed(port, tty->termios, old_termios);
|
||||
sdio_uart_change_speed(port, &tty->termios, old_termios);
|
||||
|
||||
/* Handle transition to B0 status */
|
||||
if ((old_termios->c_cflag & CBAUD) && !(cflag & CBAUD))
|
||||
|
Reference in New Issue
Block a user