xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf tools: Make is_printable_array global

Browse Source 
It's used from 2 objects in perf, so it's better to keep just one copy.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1468685480-18951-3-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa
2016-07-16 18:11:19 +02:00
committed by Arnaldo Carvalho de Melo
parent 249de6e074
commit accaed2659
4 changed files with 17 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/perf/util/python.c
View File

@@ -295,18 +295,6 @@ static bool is_tracepoint(struct pyrf_event *pevent)
return pevent->evsel->attr.type == PERF_TYPE_TRACEPOINT; return pevent->evsel->attr.type == PERF_TYPE_TRACEPOINT;
} }
static int is_printable_array(char *p, unsigned int len)
{
unsigned int i;
for (i = 0; i < len; i++) {
if (!isprint(p[i]) && !isspace(p[i]))
return 0;
}
return 1;
}
static PyObject* static PyObject*
tracepoint_field(struct pyrf_event *pe, struct format_field *field) tracepoint_field(struct pyrf_event *pe, struct format_field *field)
{ {

16
tools/perf/util/scripting-engines/trace-event-python.c
View File

@@ -386,22 +386,6 @@ exit:
return pylist; return pylist;
} }
static int is_printable_array(char *p, unsigned int len)
{
unsigned int i;
if (!p || !len || p[len - 1] != 0)
return 0;
len--;
for (i = 0; i < len; i++) {
if (!isprint(p[i]) && !isspace(p[i]))
return 0;
}
return 1;
}
static void python_process_tracepoint(struct perf_sample *sample, static void python_process_tracepoint(struct perf_sample *sample,
struct perf_evsel *evsel, struct perf_evsel *evsel,
struct addr_location *al) struct addr_location *al)

16
tools/perf/util/util.c
View File

@@ -746,3 +746,19 @@ void print_binary(unsigned char *data, size_t len,
} }
printer(BINARY_PRINT_DATA_END, -1, extra); printer(BINARY_PRINT_DATA_END, -1, extra);
} }
int is_printable_array(char *p, unsigned int len)
{
unsigned int i;
if (!p || !len || p[len - 1] != 0)
return 0;
len--;
for (i = 0; i < len; i++) {
if (!isprint(p[i]) && !isspace(p[i]))
return 0;
}
return 1;
}

1
tools/perf/util/util.h
View File

@@ -364,4 +364,5 @@ void print_binary(unsigned char *data, size_t len,
extern int sched_getcpu(void); extern int sched_getcpu(void);
#endif #endif
int is_printable_array(char *p, unsigned int len);
#endif /* GIT_COMPAT_UTIL_H */ #endif /* GIT_COMPAT_UTIL_H */