xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe

Browse Source 
commit 9b663b34c94a78f39fa2c7a8271b1f828b546e16 upstream.

Since the LED multicolor framework support was added in commit
92a81562e6 ("leds: lp55xx: Add multicolor framework support to lp55xx")
LEDs on this platform stopped working.

Author of the framework attempted to accommodate this DT to the
framework in commit b86d3d21cd ("ARM: dts: imx6dl-yapp4: Add reg property
to the lp5562 channel node") but that is not sufficient. A color property
is now required even if the multicolor framework is not used, otherwise
the driver probe fails:

  lp5562: probe of 1-0030 failed with error -22

Add the color property to fix this.

Fixes: 92a81562e6 ("leds: lp55xx: Add multicolor framework support to lp55xx")
Cc: <stable@vger.kernel.org>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michal Vokáč
2021-08-18 09:02:08 +02:00
committed by Greg Kroah-Hartman
parent 71d3ce62ac
commit ac06fe40e8
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
View File

@@ -5,6 +5,7 @@
#include <dt-bindings/gpio/gpio.h> #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/input/input.h> #include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pwm/pwm.h> #include <dt-bindings/pwm/pwm.h>
/ { / {
@@ -275,6 +276,7 @@
led-cur = /bits/ 8 <0x20>; led-cur = /bits/ 8 <0x20>;
max-cur = /bits/ 8 <0x60>; max-cur = /bits/ 8 <0x60>;
reg = <0>; reg = <0>;
color = <LED_COLOR_ID_RED>;
}; };
chan@1 { chan@1 {
@@ -282,6 +284,7 @@
led-cur = /bits/ 8 <0x20>; led-cur = /bits/ 8 <0x20>;
max-cur = /bits/ 8 <0x60>; max-cur = /bits/ 8 <0x60>;
reg = <1>; reg = <1>;
color = <LED_COLOR_ID_GREEN>;
}; };
chan@2 { chan@2 {
@@ -289,6 +292,7 @@
led-cur = /bits/ 8 <0x20>; led-cur = /bits/ 8 <0x20>;
max-cur = /bits/ 8 <0x60>; max-cur = /bits/ 8 <0x60>;
reg = <2>; reg = <2>;
color = <LED_COLOR_ID_BLUE>;
}; };
chan@3 { chan@3 {
@@ -296,6 +300,7 @@
led-cur = /bits/ 8 <0x0>; led-cur = /bits/ 8 <0x0>;
max-cur = /bits/ 8 <0x0>; max-cur = /bits/ 8 <0x0>;
reg = <3>; reg = <3>;
color = <LED_COLOR_ID_WHITE>;
}; };
}; };