mac80211: fix enabling 4-address mode on a sta vif after assoc
[ Upstream commit a5d3cbdb09ff1f52cbe040932e06c8b9915c6dad ]
Notify the driver about the 4-address mode change and also send a nulldata
packet to the AP to notify it about the change
Fixes: 1ff4e8f2de
("mac80211: notify the driver when a sta uses 4-address mode")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20210702050111.47546-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
076bc6ebce
commit
ac038f4152
@@ -152,6 +152,8 @@ static int ieee80211_change_iface(struct wiphy *wiphy,
|
|||||||
struct vif_params *params)
|
struct vif_params *params)
|
||||||
{
|
{
|
||||||
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
|
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
|
||||||
|
struct ieee80211_local *local = sdata->local;
|
||||||
|
struct sta_info *sta;
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
ret = ieee80211_if_change_type(sdata, type);
|
ret = ieee80211_if_change_type(sdata, type);
|
||||||
@@ -162,7 +164,24 @@ static int ieee80211_change_iface(struct wiphy *wiphy,
|
|||||||
RCU_INIT_POINTER(sdata->u.vlan.sta, NULL);
|
RCU_INIT_POINTER(sdata->u.vlan.sta, NULL);
|
||||||
ieee80211_check_fast_rx_iface(sdata);
|
ieee80211_check_fast_rx_iface(sdata);
|
||||||
} else if (type == NL80211_IFTYPE_STATION && params->use_4addr >= 0) {
|
} else if (type == NL80211_IFTYPE_STATION && params->use_4addr >= 0) {
|
||||||
|
struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
|
||||||
|
|
||||||
|
if (params->use_4addr == ifmgd->use_4addr)
|
||||||
|
return 0;
|
||||||
|
|
||||||
sdata->u.mgd.use_4addr = params->use_4addr;
|
sdata->u.mgd.use_4addr = params->use_4addr;
|
||||||
|
if (!ifmgd->associated)
|
||||||
|
return 0;
|
||||||
|
|
||||||
|
mutex_lock(&local->sta_mtx);
|
||||||
|
sta = sta_info_get(sdata, ifmgd->bssid);
|
||||||
|
if (sta)
|
||||||
|
drv_sta_set_4addr(local, sdata, &sta->sta,
|
||||||
|
params->use_4addr);
|
||||||
|
mutex_unlock(&local->sta_mtx);
|
||||||
|
|
||||||
|
if (params->use_4addr)
|
||||||
|
ieee80211_send_4addr_nullfunc(local, sdata);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (sdata->vif.type == NL80211_IFTYPE_MONITOR) {
|
if (sdata->vif.type == NL80211_IFTYPE_MONITOR) {
|
||||||
|
@@ -2051,6 +2051,8 @@ void ieee80211_dynamic_ps_timer(struct timer_list *t);
|
|||||||
void ieee80211_send_nullfunc(struct ieee80211_local *local,
|
void ieee80211_send_nullfunc(struct ieee80211_local *local,
|
||||||
struct ieee80211_sub_if_data *sdata,
|
struct ieee80211_sub_if_data *sdata,
|
||||||
bool powersave);
|
bool powersave);
|
||||||
|
void ieee80211_send_4addr_nullfunc(struct ieee80211_local *local,
|
||||||
|
struct ieee80211_sub_if_data *sdata);
|
||||||
void ieee80211_sta_tx_notify(struct ieee80211_sub_if_data *sdata,
|
void ieee80211_sta_tx_notify(struct ieee80211_sub_if_data *sdata,
|
||||||
struct ieee80211_hdr *hdr, bool ack, u16 tx_time);
|
struct ieee80211_hdr *hdr, bool ack, u16 tx_time);
|
||||||
|
|
||||||
|
@@ -1115,7 +1115,7 @@ void ieee80211_send_nullfunc(struct ieee80211_local *local,
|
|||||||
ieee80211_tx_skb(sdata, skb);
|
ieee80211_tx_skb(sdata, skb);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void ieee80211_send_4addr_nullfunc(struct ieee80211_local *local,
|
void ieee80211_send_4addr_nullfunc(struct ieee80211_local *local,
|
||||||
struct ieee80211_sub_if_data *sdata)
|
struct ieee80211_sub_if_data *sdata)
|
||||||
{
|
{
|
||||||
struct sk_buff *skb;
|
struct sk_buff *skb;
|
||||||
|
Reference in New Issue
Block a user