[media] media framework: rename pads init function to media_entity_pads_init()
With the MC next gen rework, what's left for media_entity_init() is to just initialize the PADs. However, certain devices, like a FLASH led/light doesn't have any input or output PAD. So, there's no reason why calling media_entity_init() would be mandatory. Also, despite its name, what this function actually does is to initialize the PADs data. So, rename it to media_entity_pads_init() in order to reflect that. The media entity actual init happens during entity register, at media_device_register_entity(). We should move init of num_links and num_backlinks to it. Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
@@ -1799,7 +1799,7 @@ static int fimc_register_capture_device(struct fimc_dev *fimc,
|
||||
vid_cap->wb_fmt.code = fmt->mbus_code;
|
||||
|
||||
vid_cap->vd_pad.flags = MEDIA_PAD_FL_SINK;
|
||||
ret = media_entity_init(&vfd->entity, 1, &vid_cap->vd_pad);
|
||||
ret = media_entity_pads_init(&vfd->entity, 1, &vid_cap->vd_pad);
|
||||
if (ret)
|
||||
goto err_free_ctx;
|
||||
|
||||
@@ -1891,7 +1891,7 @@ int fimc_initialize_capture_subdev(struct fimc_dev *fimc)
|
||||
fimc->vid_cap.sd_pads[FIMC_SD_PAD_SINK_CAM].flags = MEDIA_PAD_FL_SINK;
|
||||
fimc->vid_cap.sd_pads[FIMC_SD_PAD_SINK_FIFO].flags = MEDIA_PAD_FL_SINK;
|
||||
fimc->vid_cap.sd_pads[FIMC_SD_PAD_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
|
||||
ret = media_entity_init(&sd->entity, FIMC_SD_PADS_NUM,
|
||||
ret = media_entity_pads_init(&sd->entity, FIMC_SD_PADS_NUM,
|
||||
fimc->vid_cap.sd_pads);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
@@ -616,7 +616,7 @@ int fimc_isp_video_device_register(struct fimc_isp *isp,
|
||||
vdev->lock = &isp->video_lock;
|
||||
|
||||
iv->pad.flags = MEDIA_PAD_FL_SINK;
|
||||
ret = media_entity_init(&vdev->entity, 1, &iv->pad);
|
||||
ret = media_entity_pads_init(&vdev->entity, 1, &iv->pad);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
|
||||
|
@@ -708,7 +708,7 @@ int fimc_isp_subdev_create(struct fimc_isp *isp)
|
||||
isp->subdev_pads[FIMC_ISP_SD_PAD_SINK].flags = MEDIA_PAD_FL_SINK;
|
||||
isp->subdev_pads[FIMC_ISP_SD_PAD_SRC_FIFO].flags = MEDIA_PAD_FL_SOURCE;
|
||||
isp->subdev_pads[FIMC_ISP_SD_PAD_SRC_DMA].flags = MEDIA_PAD_FL_SOURCE;
|
||||
ret = media_entity_init(&sd->entity, FIMC_ISP_SD_PADS_NUM,
|
||||
ret = media_entity_pads_init(&sd->entity, FIMC_ISP_SD_PADS_NUM,
|
||||
isp->subdev_pads);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
@@ -1314,7 +1314,7 @@ static int fimc_lite_subdev_registered(struct v4l2_subdev *sd)
|
||||
return ret;
|
||||
|
||||
fimc->vd_pad.flags = MEDIA_PAD_FL_SINK;
|
||||
ret = media_entity_init(&vfd->entity, 1, &fimc->vd_pad);
|
||||
ret = media_entity_pads_init(&vfd->entity, 1, &fimc->vd_pad);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
|
||||
@@ -1428,7 +1428,7 @@ static int fimc_lite_create_capture_subdev(struct fimc_lite *fimc)
|
||||
fimc->subdev_pads[FLITE_SD_PAD_SINK].flags = MEDIA_PAD_FL_SINK;
|
||||
fimc->subdev_pads[FLITE_SD_PAD_SOURCE_DMA].flags = MEDIA_PAD_FL_SOURCE;
|
||||
fimc->subdev_pads[FLITE_SD_PAD_SOURCE_ISP].flags = MEDIA_PAD_FL_SOURCE;
|
||||
ret = media_entity_init(&sd->entity, FLITE_SD_PADS_NUM,
|
||||
ret = media_entity_pads_init(&sd->entity, FLITE_SD_PADS_NUM,
|
||||
fimc->subdev_pads);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
@@ -739,7 +739,7 @@ int fimc_register_m2m_device(struct fimc_dev *fimc,
|
||||
return PTR_ERR(fimc->m2m.m2m_dev);
|
||||
}
|
||||
|
||||
ret = media_entity_init(&vfd->entity, 0, NULL);
|
||||
ret = media_entity_pads_init(&vfd->entity, 0, NULL);
|
||||
if (ret)
|
||||
goto err_me;
|
||||
|
||||
|
@@ -866,7 +866,7 @@ static int s5pcsis_probe(struct platform_device *pdev)
|
||||
|
||||
state->pads[CSIS_PAD_SINK].flags = MEDIA_PAD_FL_SINK;
|
||||
state->pads[CSIS_PAD_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
|
||||
ret = media_entity_init(&state->sd.entity,
|
||||
ret = media_entity_pads_init(&state->sd.entity,
|
||||
CSIS_PADS_NUM, state->pads);
|
||||
if (ret < 0)
|
||||
goto e_clkdis;
|
||||
|
Reference in New Issue
Block a user