drm/tegra: Move IOMMU group into host1x client
Handling of the IOMMU group attachment is common to all clients, so move the group into the client to simplify code. Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
@@ -1068,8 +1068,7 @@ int tegra_drm_unregister_client(struct tegra_drm *tegra,
|
||||
return 0;
|
||||
}
|
||||
|
||||
struct iommu_group *host1x_client_iommu_attach(struct host1x_client *client,
|
||||
bool shared)
|
||||
int host1x_client_iommu_attach(struct host1x_client *client, bool shared)
|
||||
{
|
||||
struct drm_device *drm = dev_get_drvdata(client->parent);
|
||||
struct tegra_drm *tegra = drm->dev_private;
|
||||
@@ -1080,7 +1079,7 @@ struct iommu_group *host1x_client_iommu_attach(struct host1x_client *client,
|
||||
group = iommu_group_get(client->dev);
|
||||
if (!group) {
|
||||
dev_err(client->dev, "failed to get IOMMU group\n");
|
||||
return ERR_PTR(-ENODEV);
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
if (!shared || (shared && (group != tegra->group))) {
|
||||
@@ -1095,7 +1094,7 @@ struct iommu_group *host1x_client_iommu_attach(struct host1x_client *client,
|
||||
err = iommu_attach_group(tegra->domain, group);
|
||||
if (err < 0) {
|
||||
iommu_group_put(group);
|
||||
return ERR_PTR(err);
|
||||
return err;
|
||||
}
|
||||
|
||||
if (shared && !tegra->group)
|
||||
@@ -1103,22 +1102,23 @@ struct iommu_group *host1x_client_iommu_attach(struct host1x_client *client,
|
||||
}
|
||||
}
|
||||
|
||||
return group;
|
||||
client->group = group;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
void host1x_client_iommu_detach(struct host1x_client *client,
|
||||
struct iommu_group *group)
|
||||
void host1x_client_iommu_detach(struct host1x_client *client)
|
||||
{
|
||||
struct drm_device *drm = dev_get_drvdata(client->parent);
|
||||
struct tegra_drm *tegra = drm->dev_private;
|
||||
|
||||
if (group) {
|
||||
if (group == tegra->group) {
|
||||
iommu_detach_group(tegra->domain, group);
|
||||
if (client->group) {
|
||||
if (client->group == tegra->group) {
|
||||
iommu_detach_group(tegra->domain, client->group);
|
||||
tegra->group = NULL;
|
||||
}
|
||||
|
||||
iommu_group_put(group);
|
||||
iommu_group_put(client->group);
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user