Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs update from Al Viro: - big one - consolidation of descriptor-related logics; almost all of that is moved to fs/file.c (BTW, I'm seriously tempted to rename the result to fd.c. As it is, we have a situation when file_table.c is about handling of struct file and file.c is about handling of descriptor tables; the reasons are historical - file_table.c used to be about a static array of struct file we used to have way back). A lot of stray ends got cleaned up and converted to saner primitives, disgusting mess in android/binder.c is still disgusting, but at least doesn't poke so much in descriptor table guts anymore. A bunch of relatively minor races got fixed in process, plus an ext4 struct file leak. - related thing - fget_light() partially unuglified; see fdget() in there (and yes, it generates the code as good as we used to have). - also related - bits of Cyrill's procfs stuff that got entangled into that work; _not_ all of it, just the initial move to fs/proc/fd.c and switch of fdinfo to seq_file. - Alex's fs/coredump.c spiltoff - the same story, had been easier to take that commit than mess with conflicts. The rest is a separate pile, this was just a mechanical code movement. - a few misc patches all over the place. Not all for this cycle, there'll be more (and quite a few currently sit in akpm's tree)." Fix up trivial conflicts in the android binder driver, and some fairly simple conflicts due to two different changes to the sock_alloc_file() interface ("take descriptor handling from sock_alloc_file() to callers" vs "net: Providing protocol type via system.sockprotoname xattr of /proc/PID/fd entries" adding a dentry name to the socket) * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (72 commits) MAX_LFS_FILESIZE should be a loff_t compat: fs: Generic compat_sys_sendfile implementation fs: push rcu_barrier() from deactivate_locked_super() to filesystems btrfs: reada_extent doesn't need kref for refcount coredump: move core dump functionality into its own file coredump: prevent double-free on an error path in core dumper usb/gadget: fix misannotations fcntl: fix misannotations ceph: don't abuse d_delete() on failure exits hypfs: ->d_parent is never NULL or negative vfs: delete surplus inode NULL check switch simple cases of fget_light to fdget new helpers: fdget()/fdput() switch o2hb_region_dev_write() to fget_light() proc_map_files_readdir(): don't bother with grabbing files make get_file() return its argument vhost_set_vring(): turn pollstart/pollstop into bool switch prctl_set_mm_exe_file() to fget_light() switch xfs_find_handle() to fget_light() switch xfs_swapext() to fget_light() ...
此提交包含在:
@@ -48,44 +48,44 @@ xfs_swapext(
|
||||
xfs_swapext_t *sxp)
|
||||
{
|
||||
xfs_inode_t *ip, *tip;
|
||||
struct file *file, *tmp_file;
|
||||
struct fd f, tmp;
|
||||
int error = 0;
|
||||
|
||||
/* Pull information for the target fd */
|
||||
file = fget((int)sxp->sx_fdtarget);
|
||||
if (!file) {
|
||||
f = fdget((int)sxp->sx_fdtarget);
|
||||
if (!f.file) {
|
||||
error = XFS_ERROR(EINVAL);
|
||||
goto out;
|
||||
}
|
||||
|
||||
if (!(file->f_mode & FMODE_WRITE) ||
|
||||
!(file->f_mode & FMODE_READ) ||
|
||||
(file->f_flags & O_APPEND)) {
|
||||
if (!(f.file->f_mode & FMODE_WRITE) ||
|
||||
!(f.file->f_mode & FMODE_READ) ||
|
||||
(f.file->f_flags & O_APPEND)) {
|
||||
error = XFS_ERROR(EBADF);
|
||||
goto out_put_file;
|
||||
}
|
||||
|
||||
tmp_file = fget((int)sxp->sx_fdtmp);
|
||||
if (!tmp_file) {
|
||||
tmp = fdget((int)sxp->sx_fdtmp);
|
||||
if (!tmp.file) {
|
||||
error = XFS_ERROR(EINVAL);
|
||||
goto out_put_file;
|
||||
}
|
||||
|
||||
if (!(tmp_file->f_mode & FMODE_WRITE) ||
|
||||
!(tmp_file->f_mode & FMODE_READ) ||
|
||||
(tmp_file->f_flags & O_APPEND)) {
|
||||
if (!(tmp.file->f_mode & FMODE_WRITE) ||
|
||||
!(tmp.file->f_mode & FMODE_READ) ||
|
||||
(tmp.file->f_flags & O_APPEND)) {
|
||||
error = XFS_ERROR(EBADF);
|
||||
goto out_put_tmp_file;
|
||||
}
|
||||
|
||||
if (IS_SWAPFILE(file->f_path.dentry->d_inode) ||
|
||||
IS_SWAPFILE(tmp_file->f_path.dentry->d_inode)) {
|
||||
if (IS_SWAPFILE(f.file->f_path.dentry->d_inode) ||
|
||||
IS_SWAPFILE(tmp.file->f_path.dentry->d_inode)) {
|
||||
error = XFS_ERROR(EINVAL);
|
||||
goto out_put_tmp_file;
|
||||
}
|
||||
|
||||
ip = XFS_I(file->f_path.dentry->d_inode);
|
||||
tip = XFS_I(tmp_file->f_path.dentry->d_inode);
|
||||
ip = XFS_I(f.file->f_path.dentry->d_inode);
|
||||
tip = XFS_I(tmp.file->f_path.dentry->d_inode);
|
||||
|
||||
if (ip->i_mount != tip->i_mount) {
|
||||
error = XFS_ERROR(EINVAL);
|
||||
@@ -105,9 +105,9 @@ xfs_swapext(
|
||||
error = xfs_swap_extents(ip, tip, sxp);
|
||||
|
||||
out_put_tmp_file:
|
||||
fput(tmp_file);
|
||||
fdput(tmp);
|
||||
out_put_file:
|
||||
fput(file);
|
||||
fdput(f);
|
||||
out:
|
||||
return error;
|
||||
}
|
||||
|
@@ -70,16 +70,16 @@ xfs_find_handle(
|
||||
int hsize;
|
||||
xfs_handle_t handle;
|
||||
struct inode *inode;
|
||||
struct file *file = NULL;
|
||||
struct fd f;
|
||||
struct path path;
|
||||
int error;
|
||||
struct xfs_inode *ip;
|
||||
|
||||
if (cmd == XFS_IOC_FD_TO_HANDLE) {
|
||||
file = fget(hreq->fd);
|
||||
if (!file)
|
||||
f = fdget(hreq->fd);
|
||||
if (!f.file)
|
||||
return -EBADF;
|
||||
inode = file->f_path.dentry->d_inode;
|
||||
inode = f.file->f_path.dentry->d_inode;
|
||||
} else {
|
||||
error = user_lpath((const char __user *)hreq->path, &path);
|
||||
if (error)
|
||||
@@ -134,7 +134,7 @@ xfs_find_handle(
|
||||
|
||||
out_put:
|
||||
if (cmd == XFS_IOC_FD_TO_HANDLE)
|
||||
fput(file);
|
||||
fdput(f);
|
||||
else
|
||||
path_put(&path);
|
||||
return error;
|
||||
|
@@ -1506,6 +1506,11 @@ xfs_init_zones(void)
|
||||
STATIC void
|
||||
xfs_destroy_zones(void)
|
||||
{
|
||||
/*
|
||||
* Make sure all delayed rcu free are flushed before we
|
||||
* destroy caches.
|
||||
*/
|
||||
rcu_barrier();
|
||||
kmem_zone_destroy(xfs_ili_zone);
|
||||
kmem_zone_destroy(xfs_inode_zone);
|
||||
kmem_zone_destroy(xfs_efi_zone);
|
||||
|
新增問題並參考
封鎖使用者