Revert "kernfs, sysfs, driver-core: implement kernfs_remove_self() and its wrappers"
This reverts commit 1ae06819c7
.
Tejun writes:
I'm sorry but can you please revert the whole series?
get_active() waiting while a node is deactivated has potential
to lead to deadlock and that deactivate/reactivate interface is
something fundamentally flawed and that cgroup will have to work
with the remove_self() like everybody else. IOW, I think the
first posting was correct.
Cc: Tejun Heo <tj@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
@@ -43,8 +43,6 @@ enum kernfs_node_flag {
|
||||
KERNFS_HAS_MMAP = 0x0080,
|
||||
KERNFS_LOCKDEP = 0x0100,
|
||||
KERNFS_STATIC_NAME = 0x0200,
|
||||
KERNFS_SUICIDAL = 0x0400,
|
||||
KERNFS_SUICIDED = 0x0800,
|
||||
};
|
||||
|
||||
/* type-specific structures for kernfs_node union members */
|
||||
@@ -241,7 +239,6 @@ void kernfs_reactivate(struct kernfs_node *kn);
|
||||
void kernfs_deactivate_self(struct kernfs_node *kn);
|
||||
void kernfs_reactivate_self(struct kernfs_node *kn);
|
||||
void kernfs_remove(struct kernfs_node *kn);
|
||||
bool kernfs_remove_self(struct kernfs_node *kn);
|
||||
int kernfs_remove_by_name_ns(struct kernfs_node *parent, const char *name,
|
||||
const void *ns);
|
||||
int kernfs_rename_ns(struct kernfs_node *kn, struct kernfs_node *new_parent,
|
||||
@@ -299,9 +296,6 @@ kernfs_create_link(struct kernfs_node *parent, const char *name,
|
||||
|
||||
static inline void kernfs_remove(struct kernfs_node *kn) { }
|
||||
|
||||
static inline bool kernfs_remove_self(struct kernfs_node *kn)
|
||||
{ return false; }
|
||||
|
||||
static inline int kernfs_remove_by_name_ns(struct kernfs_node *kn,
|
||||
const char *name, const void *ns)
|
||||
{ return -ENOSYS; }
|
||||
|
Reference in New Issue
Block a user