gpio: gpiolib: Allow GPIO IRQs to lazy disable
With 'commit461c1a7d47
("gpiolib: override irq_enable/disable")' gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable callback is implemented then genirq takes unlazy path to disable irq. Underlying irqchip may not want to implement irq_disable callback to lazy disable irq when client drivers invokes disable_irq(). By overriding irq_disable callback, gpiolib ends up always unlazy disabling IRQ. Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only if irqchip implemented irq_disable. In cases where irq_disable is not implemented irq_mask is overridden. Similarly override irq_enable callback only if irqchip implemented irq_enable otherwise irq_unmask is overridden. Fixes:461c1a7d47
("gpiolib: override irq_enable/disable") Signed-off-by: Maulik Shah <mkshah@codeaurora.org> Tested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Link: https://lore.kernel.org/r/1590253873-11556-2-git-send-email-mkshah@codeaurora.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:

committed by
Linus Walleij

parent
a34d5e5631
commit
a8173820f4
@@ -253,6 +253,19 @@ struct gpio_irq_chip {
|
||||
* Store old irq_chip irq_disable callback
|
||||
*/
|
||||
void (*irq_disable)(struct irq_data *data);
|
||||
/**
|
||||
* @irq_unmask:
|
||||
*
|
||||
* Store old irq_chip irq_unmask callback
|
||||
*/
|
||||
void (*irq_unmask)(struct irq_data *data);
|
||||
|
||||
/**
|
||||
* @irq_mask:
|
||||
*
|
||||
* Store old irq_chip irq_mask callback
|
||||
*/
|
||||
void (*irq_mask)(struct irq_data *data);
|
||||
};
|
||||
|
||||
/**
|
||||
|
Reference in New Issue
Block a user