drm/omap: Use the drm_panel_bridge API
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200226112514.12455-25-laurent.pinchart@ideasonboard.com
This commit is contained in:

committed by
Tomi Valkeinen

parent
514fc91083
commit
a779618b4a
@@ -21,6 +21,7 @@
|
||||
int omapdss_device_init_output(struct omap_dss_device *out)
|
||||
{
|
||||
struct device_node *remote_node;
|
||||
int ret;
|
||||
|
||||
remote_node = of_graph_get_remote_node(out->dev->of_node,
|
||||
ffs(out->of_ports) - 1, 0);
|
||||
@@ -39,17 +40,39 @@ int omapdss_device_init_output(struct omap_dss_device *out)
|
||||
|
||||
if (out->next && out->type != out->next->type) {
|
||||
dev_err(out->dev, "output type and display type don't match\n");
|
||||
omapdss_device_put(out->next);
|
||||
out->next = NULL;
|
||||
return -EINVAL;
|
||||
ret = -EINVAL;
|
||||
goto error;
|
||||
}
|
||||
|
||||
return out->next || out->bridge || out->panel ? 0 : -EPROBE_DEFER;
|
||||
if (out->panel) {
|
||||
struct drm_bridge *bridge;
|
||||
|
||||
bridge = drm_panel_bridge_add(out->panel);
|
||||
if (IS_ERR(bridge)) {
|
||||
dev_err(out->dev,
|
||||
"unable to create panel bridge (%ld)\n",
|
||||
PTR_ERR(bridge));
|
||||
ret = PTR_ERR(bridge);
|
||||
goto error;
|
||||
}
|
||||
|
||||
out->bridge = bridge;
|
||||
}
|
||||
|
||||
return out->next || out->bridge ? 0 : -EPROBE_DEFER;
|
||||
|
||||
error:
|
||||
omapdss_device_put(out->next);
|
||||
out->next = NULL;
|
||||
return ret;
|
||||
}
|
||||
EXPORT_SYMBOL(omapdss_device_init_output);
|
||||
|
||||
void omapdss_device_cleanup_output(struct omap_dss_device *out)
|
||||
{
|
||||
if (out->bridge && out->panel)
|
||||
drm_panel_bridge_remove(out->bridge);
|
||||
|
||||
if (out->next)
|
||||
omapdss_device_put(out->next);
|
||||
}
|
||||
|
Reference in New Issue
Block a user