xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: dapm: Potential small memory leak in dapm_cnew_widget()

Browse Source 
We should free "w" on the error path.

Fixes: 199ed3e81c ("ASoC: dapm: fix use-after-free issue with dailink sname")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Dan Carpenter
2019-02-19 15:04:27 +03:00
committed by Mark Brown
parent f89aea0f13
commit a6d9cef30e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/soc-dapm.c
View File

@@ -332,9 +332,11 @@ static inline struct snd_soc_dapm_widget *dapm_cnew_widget(
*/ */
if (_widget->sname) { if (_widget->sname) {
w->sname = kstrdup_const(_widget->sname, GFP_KERNEL); w->sname = kstrdup_const(_widget->sname, GFP_KERNEL);
if (!w->sname) if (!w->sname) {
kfree(w);
return NULL; return NULL;
} }
}
return w; return w;
} }