net: phy: switch remaining users to phy_(read|write)_mmd()
Switch everyone over to using phy_read_mmd() and phy_write_mmd() now that they are able to handle both Clause 22 indirect addressing and Clause 45 direct addressing methods to the MMD registers. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
5f61367729
commit
a6d99fcd3f
@@ -133,14 +133,14 @@ static int dp83867_config_port_mirroring(struct phy_device *phydev)
|
||||
(struct dp83867_private *)phydev->priv;
|
||||
u16 val;
|
||||
|
||||
val = phy_read_mmd_indirect(phydev, DP83867_CFG4, DP83867_DEVADDR);
|
||||
val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_CFG4);
|
||||
|
||||
if (dp83867->port_mirroring == DP83867_PORT_MIRROING_EN)
|
||||
val |= DP83867_CFG4_PORT_MIRROR_EN;
|
||||
else
|
||||
val &= ~DP83867_CFG4_PORT_MIRROR_EN;
|
||||
|
||||
phy_write_mmd_indirect(phydev, DP83867_CFG4, DP83867_DEVADDR, val);
|
||||
phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_CFG4, val);
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -231,8 +231,7 @@ static int dp83867_config_init(struct phy_device *phydev)
|
||||
* register's bit 11 (marked as RESERVED).
|
||||
*/
|
||||
|
||||
bs = phy_read_mmd_indirect(phydev, DP83867_STRAP_STS1,
|
||||
DP83867_DEVADDR);
|
||||
bs = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_STRAP_STS1);
|
||||
if (bs & DP83867_STRAP_STS1_RESERVED)
|
||||
val &= ~DP83867_PHYCR_RESERVED_MASK;
|
||||
|
||||
@@ -243,8 +242,7 @@ static int dp83867_config_init(struct phy_device *phydev)
|
||||
|
||||
if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
|
||||
(phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
|
||||
val = phy_read_mmd_indirect(phydev, DP83867_RGMIICTL,
|
||||
DP83867_DEVADDR);
|
||||
val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);
|
||||
|
||||
if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
|
||||
val |= (DP83867_RGMII_TX_CLK_DELAY_EN | DP83867_RGMII_RX_CLK_DELAY_EN);
|
||||
@@ -255,25 +253,24 @@ static int dp83867_config_init(struct phy_device *phydev)
|
||||
if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)
|
||||
val |= DP83867_RGMII_RX_CLK_DELAY_EN;
|
||||
|
||||
phy_write_mmd_indirect(phydev, DP83867_RGMIICTL,
|
||||
DP83867_DEVADDR, val);
|
||||
phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL, val);
|
||||
|
||||
delay = (dp83867->rx_id_delay |
|
||||
(dp83867->tx_id_delay << DP83867_RGMII_TX_CLK_DELAY_SHIFT));
|
||||
|
||||
phy_write_mmd_indirect(phydev, DP83867_RGMIIDCTL,
|
||||
DP83867_DEVADDR, delay);
|
||||
phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIIDCTL,
|
||||
delay);
|
||||
|
||||
if (dp83867->io_impedance >= 0) {
|
||||
val = phy_read_mmd_indirect(phydev, DP83867_IO_MUX_CFG,
|
||||
DP83867_DEVADDR);
|
||||
val = phy_read_mmd(phydev, DP83867_DEVADDR,
|
||||
DP83867_IO_MUX_CFG);
|
||||
|
||||
val &= ~DP83867_IO_MUX_CFG_IO_IMPEDANCE_CTRL;
|
||||
val |= dp83867->io_impedance &
|
||||
DP83867_IO_MUX_CFG_IO_IMPEDANCE_CTRL;
|
||||
|
||||
phy_write_mmd_indirect(phydev, DP83867_IO_MUX_CFG,
|
||||
DP83867_DEVADDR, val);
|
||||
phy_write_mmd(phydev, DP83867_DEVADDR,
|
||||
DP83867_IO_MUX_CFG, val);
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user