xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/smc: fix using of uninitialized completions

Browse Source 
[ Upstream commit 6d7373dabfd3933ee30c40fc8c09d2a788f6ece1 ]

In smc_wr_tx_send_wait() the completion on index specified by
pend->idx is initialized and after smc_wr_tx_send() was called the wait
for completion starts. pend->idx is used to get the correct index for
the wait, but the pend structure could already be cleared in
smc_wr_tx_process_cqe().
Introduce pnd_idx to hold and use a local copy of the correct index.

Fixes: 09c61d24f9 ("net/smc: wait for departure of an IB message")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Karsten Graul
2021-12-27 14:35:30 +01:00
committed by Greg Kroah-Hartman
parent 769d14abd3
commit a67becdaa8
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/smc/smc_wr.c
View File

@@ -288,18 +288,20 @@ int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
unsigned long timeout) unsigned long timeout)
{ {
struct smc_wr_tx_pend *pend; struct smc_wr_tx_pend *pend;
u32 pnd_idx;
int rc; int rc;
pend = container_of(priv, struct smc_wr_tx_pend, priv); pend = container_of(priv, struct smc_wr_tx_pend, priv);
pend->compl_requested = 1; pend->compl_requested = 1;
init_completion(&link->wr_tx_compl[pend->idx]); pnd_idx = pend->idx;
init_completion(&link->wr_tx_compl[pnd_idx]);
rc = smc_wr_tx_send(link, priv); rc = smc_wr_tx_send(link, priv);
if (rc) if (rc)
return rc; return rc;
/* wait for completion by smc_wr_tx_process_cqe() */ /* wait for completion by smc_wr_tx_process_cqe() */
rc = wait_for_completion_interruptible_timeout( rc = wait_for_completion_interruptible_timeout(
&link->wr_tx_compl[pend->idx], timeout); &link->wr_tx_compl[pnd_idx], timeout);
if (rc <= 0) if (rc <= 0)
rc = -ENODATA; rc = -ENODATA;
if (rc > 0) if (rc > 0)