Merge tag 'block-5.8-2020-06-11' of git://git.kernel.dk/linux-block
Pull block fixes from Jens Axboe: "Some followup fixes for this merge window. In particular: - Seqcount write missing preemption disable for stats (Ahmed) - blktrace fixes (Chaitanya) - Redundant initializations (Colin) - Various small NVMe fixes (Chaitanya, Christoph, Daniel, Max, Niklas, Rikard) - loop flag bug regression fix (Martijn) - blk-mq tagging fixes (Christoph, Ming)" * tag 'block-5.8-2020-06-11' of git://git.kernel.dk/linux-block: umem: remove redundant initialization of variable ret pktcdvd: remove redundant initialization of variable ret nvmet: fail outstanding host posted AEN req nvme-pci: use simple suspend when a HMB is enabled nvme-fc: don't call nvme_cleanup_cmd() for AENs nvmet-tcp: constify nvmet_tcp_ops nvme-tcp: constify nvme_tcp_mq_ops and nvme_tcp_admin_mq_ops nvme: do not call del_gendisk() on a disk that was never added blk-mq: fix blk_mq_all_tag_iter blk-mq: split out a __blk_mq_get_driver_tag helper blktrace: fix endianness for blk_log_remap() blktrace: fix endianness in get_pdu_int() blktrace: use errno instead of bi_status block: nr_sects_write(): Disable preemption on seqcount write block: remove the error argument to the block_bio_complete tracepoint loop: Fix wrong masking of status flags block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed
This commit is contained in:
@@ -885,10 +885,10 @@ static void blk_add_trace_bio_bounce(void *ignore,
|
||||
}
|
||||
|
||||
static void blk_add_trace_bio_complete(void *ignore,
|
||||
struct request_queue *q, struct bio *bio,
|
||||
int error)
|
||||
struct request_queue *q, struct bio *bio)
|
||||
{
|
||||
blk_add_trace_bio(q, bio, BLK_TA_COMPLETE, error);
|
||||
blk_add_trace_bio(q, bio, BLK_TA_COMPLETE,
|
||||
blk_status_to_errno(bio->bi_status));
|
||||
}
|
||||
|
||||
static void blk_add_trace_bio_backmerge(void *ignore,
|
||||
@@ -995,8 +995,10 @@ static void blk_add_trace_split(void *ignore,
|
||||
|
||||
__blk_add_trace(bt, bio->bi_iter.bi_sector,
|
||||
bio->bi_iter.bi_size, bio_op(bio), bio->bi_opf,
|
||||
BLK_TA_SPLIT, bio->bi_status, sizeof(rpdu),
|
||||
&rpdu, blk_trace_bio_get_cgid(q, bio));
|
||||
BLK_TA_SPLIT,
|
||||
blk_status_to_errno(bio->bi_status),
|
||||
sizeof(rpdu), &rpdu,
|
||||
blk_trace_bio_get_cgid(q, bio));
|
||||
}
|
||||
rcu_read_unlock();
|
||||
}
|
||||
@@ -1033,7 +1035,8 @@ static void blk_add_trace_bio_remap(void *ignore,
|
||||
r.sector_from = cpu_to_be64(from);
|
||||
|
||||
__blk_add_trace(bt, bio->bi_iter.bi_sector, bio->bi_iter.bi_size,
|
||||
bio_op(bio), bio->bi_opf, BLK_TA_REMAP, bio->bi_status,
|
||||
bio_op(bio), bio->bi_opf, BLK_TA_REMAP,
|
||||
blk_status_to_errno(bio->bi_status),
|
||||
sizeof(r), &r, blk_trace_bio_get_cgid(q, bio));
|
||||
rcu_read_unlock();
|
||||
}
|
||||
@@ -1253,21 +1256,10 @@ static inline __u16 t_error(const struct trace_entry *ent)
|
||||
|
||||
static __u64 get_pdu_int(const struct trace_entry *ent, bool has_cg)
|
||||
{
|
||||
const __u64 *val = pdu_start(ent, has_cg);
|
||||
const __be64 *val = pdu_start(ent, has_cg);
|
||||
return be64_to_cpu(*val);
|
||||
}
|
||||
|
||||
static void get_pdu_remap(const struct trace_entry *ent,
|
||||
struct blk_io_trace_remap *r, bool has_cg)
|
||||
{
|
||||
const struct blk_io_trace_remap *__r = pdu_start(ent, has_cg);
|
||||
__u64 sector_from = __r->sector_from;
|
||||
|
||||
r->device_from = be32_to_cpu(__r->device_from);
|
||||
r->device_to = be32_to_cpu(__r->device_to);
|
||||
r->sector_from = be64_to_cpu(sector_from);
|
||||
}
|
||||
|
||||
typedef void (blk_log_action_t) (struct trace_iterator *iter, const char *act,
|
||||
bool has_cg);
|
||||
|
||||
@@ -1407,13 +1399,13 @@ static void blk_log_with_error(struct trace_seq *s,
|
||||
|
||||
static void blk_log_remap(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
|
||||
{
|
||||
struct blk_io_trace_remap r = { .device_from = 0, };
|
||||
const struct blk_io_trace_remap *__r = pdu_start(ent, has_cg);
|
||||
|
||||
get_pdu_remap(ent, &r, has_cg);
|
||||
trace_seq_printf(s, "%llu + %u <- (%d,%d) %llu\n",
|
||||
t_sector(ent), t_sec(ent),
|
||||
MAJOR(r.device_from), MINOR(r.device_from),
|
||||
(unsigned long long)r.sector_from);
|
||||
MAJOR(be32_to_cpu(__r->device_from)),
|
||||
MINOR(be32_to_cpu(__r->device_from)),
|
||||
be64_to_cpu(__r->sector_from));
|
||||
}
|
||||
|
||||
static void blk_log_plug(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
|
||||
|
Reference in New Issue
Block a user