net: deprecate eth_change_mtu, remove usage
With centralized MTU checking, there's nothing productive done by eth_change_mtu that isn't already done in dev_set_mtu, so mark it as deprecated and remove all usage of it in the kernel. All callers have been audited for calls to alloc_etherdev* or ether_setup directly, which means they all have a valid dev->min_mtu and dev->max_mtu. Now eth_change_mtu prints out a netdev_warn about being deprecated, for the benefit of out-of-tree drivers that might be utilizing it. Of note, dvb_net.c actually had dev->mtu = 4096, while using eth_change_mtu, meaning that if you ever tried changing it's mtu, you couldn't set it above 1500 anymore. It's now getting dev->max_mtu also set to 4096 to remedy that. v2: fix up lantiq_etop, missed breakage due to drive not compiling on x86 CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

orang tua
61e84623ac
melakukan
a52ad514fd
@@ -1068,7 +1068,6 @@ static const struct net_device_ops cpmac_netdev_ops = {
|
||||
.ndo_tx_timeout = cpmac_tx_timeout,
|
||||
.ndo_set_rx_mode = cpmac_set_multicast_list,
|
||||
.ndo_do_ioctl = cpmac_ioctl,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
};
|
||||
|
@@ -1883,7 +1883,6 @@ static const struct net_device_ops cpsw_netdev_ops = {
|
||||
.ndo_set_mac_address = cpsw_ndo_set_mac_address,
|
||||
.ndo_do_ioctl = cpsw_ndo_ioctl,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_tx_timeout = cpsw_ndo_tx_timeout,
|
||||
.ndo_set_rx_mode = cpsw_ndo_set_rx_mode,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
@@ -772,7 +772,6 @@ static const struct net_device_ops tlan_netdev_ops = {
|
||||
.ndo_get_stats = tlan_get_stats,
|
||||
.ndo_set_rx_mode = tlan_set_multicast_list,
|
||||
.ndo_do_ioctl = tlan_ioctl,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
Reference in New Issue
Block a user