net: deprecate eth_change_mtu, remove usage
With centralized MTU checking, there's nothing productive done by eth_change_mtu that isn't already done in dev_set_mtu, so mark it as deprecated and remove all usage of it in the kernel. All callers have been audited for calls to alloc_etherdev* or ether_setup directly, which means they all have a valid dev->min_mtu and dev->max_mtu. Now eth_change_mtu prints out a netdev_warn about being deprecated, for the benefit of out-of-tree drivers that might be utilizing it. Of note, dvb_net.c actually had dev->mtu = 4096, while using eth_change_mtu, meaning that if you ever tried changing it's mtu, you couldn't set it above 1500 anymore. It's now getting dev->max_mtu also set to 4096 to remedy that. v2: fix up lantiq_etop, missed breakage due to drive not compiling on x86 CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
61e84623ac
commit
a52ad514fd
@@ -313,7 +313,6 @@ static const struct net_device_ops epic_netdev_ops = {
|
||||
.ndo_get_stats = epic_get_stats,
|
||||
.ndo_set_rx_mode = set_rx_mode,
|
||||
.ndo_do_ioctl = netdev_ioctl,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
};
|
||||
|
@@ -1753,7 +1753,6 @@ static const struct net_device_ops smc911x_netdev_ops = {
|
||||
.ndo_start_xmit = smc911x_hard_start_xmit,
|
||||
.ndo_tx_timeout = smc911x_timeout,
|
||||
.ndo_set_rx_mode = smc911x_set_multicast_list,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
@@ -809,7 +809,6 @@ static const struct net_device_ops smc_netdev_ops = {
|
||||
.ndo_start_xmit = smc_wait_to_send_packet,
|
||||
.ndo_tx_timeout = smc_timeout,
|
||||
.ndo_set_rx_mode = smc_set_multicast_list,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
};
|
||||
|
@@ -294,7 +294,6 @@ static const struct net_device_ops smc_netdev_ops = {
|
||||
.ndo_set_config = s9k_config,
|
||||
.ndo_set_rx_mode = set_rx_mode,
|
||||
.ndo_do_ioctl = smc_ioctl,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
};
|
||||
|
@@ -1762,7 +1762,6 @@ static const struct net_device_ops smc_netdev_ops = {
|
||||
.ndo_start_xmit = smc_hard_start_xmit,
|
||||
.ndo_tx_timeout = smc_timeout,
|
||||
.ndo_set_rx_mode = smc_set_multicast_list,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
@@ -2152,7 +2152,6 @@ static const struct net_device_ops smsc911x_netdev_ops = {
|
||||
.ndo_get_stats = smsc911x_get_stats,
|
||||
.ndo_set_rx_mode = smsc911x_set_multicast_list,
|
||||
.ndo_do_ioctl = smsc911x_do_ioctl,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
.ndo_set_mac_address = smsc911x_set_mac_address,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
Reference in New Issue
Block a user