net: deprecate eth_change_mtu, remove usage
With centralized MTU checking, there's nothing productive done by eth_change_mtu that isn't already done in dev_set_mtu, so mark it as deprecated and remove all usage of it in the kernel. All callers have been audited for calls to alloc_etherdev* or ether_setup directly, which means they all have a valid dev->min_mtu and dev->max_mtu. Now eth_change_mtu prints out a netdev_warn about being deprecated, for the benefit of out-of-tree drivers that might be utilizing it. Of note, dvb_net.c actually had dev->mtu = 4096, while using eth_change_mtu, meaning that if you ever tried changing it's mtu, you couldn't set it above 1500 anymore. It's now getting dev->max_mtu also set to 4096 to remedy that. v2: fix up lantiq_etop, missed breakage due to drive not compiling on x86 CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
61e84623ac
commit
a52ad514fd
@@ -1956,7 +1956,6 @@ static const struct net_device_ops de_netdev_ops = {
|
||||
.ndo_start_xmit = de_start_xmit,
|
||||
.ndo_get_stats = de_get_stats,
|
||||
.ndo_tx_timeout = de_tx_timeout,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
};
|
||||
|
@@ -1085,7 +1085,6 @@ static const struct net_device_ops de4x5_netdev_ops = {
|
||||
.ndo_get_stats = de4x5_get_stats,
|
||||
.ndo_set_rx_mode = set_multicast_list,
|
||||
.ndo_do_ioctl = de4x5_ioctl,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address= eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
};
|
||||
|
@@ -352,7 +352,6 @@ static const struct net_device_ops netdev_ops = {
|
||||
.ndo_stop = dmfe_stop,
|
||||
.ndo_start_xmit = dmfe_start_xmit,
|
||||
.ndo_set_rx_mode = dmfe_set_filter_mode,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
@@ -1282,7 +1282,6 @@ static const struct net_device_ops tulip_netdev_ops = {
|
||||
.ndo_get_stats = tulip_get_stats,
|
||||
.ndo_do_ioctl = private_ioctl,
|
||||
.ndo_set_rx_mode = set_rx_mode,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
@@ -269,7 +269,6 @@ static const struct net_device_ops netdev_ops = {
|
||||
.ndo_stop = uli526x_stop,
|
||||
.ndo_start_xmit = uli526x_start_xmit,
|
||||
.ndo_set_rx_mode = uli526x_set_filter_mode,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
@@ -353,7 +353,6 @@ static const struct net_device_ops netdev_ops = {
|
||||
.ndo_set_rx_mode = set_rx_mode,
|
||||
.ndo_do_ioctl = netdev_ioctl,
|
||||
.ndo_tx_timeout = tx_timeout,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
};
|
||||
|
@@ -174,7 +174,6 @@ static const struct net_device_ops netdev_ops = {
|
||||
.ndo_open = xircom_open,
|
||||
.ndo_stop = xircom_close,
|
||||
.ndo_start_xmit = xircom_start_xmit,
|
||||
.ndo_change_mtu = eth_change_mtu,
|
||||
.ndo_set_mac_address = eth_mac_addr,
|
||||
.ndo_validate_addr = eth_validate_addr,
|
||||
#ifdef CONFIG_NET_POLL_CONTROLLER
|
||||
|
Reference in New Issue
Block a user